-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Geospatial custom fields and Map/Attribute viewer to Record view #221
base: geospatial
Are you sure you want to change the base?
Conversation
"https://*.basemaps.cartocdn.com", | ||
"https://maps-public.geo.nyu.edu", | ||
"https://maps-restricted.geo.nyu.edu", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are here to allow pulling content from external sources on the front-end.
@@ -421,6 +429,8 @@ if APP_ENVIRONMENT == 'local': | |||
'[email protected]': 'adminUV' | |||
} | |||
|
|||
RATELIMIT_ENABLED = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only enabled in local
and to allow bulk loading data via the REST API.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might ask somebody else to look at javascript/css part, everything else looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there. The code looks good. Since we don't have a linter rules file or a document outlining best practices, I will keep it short.
Error Handling: The fetch call log errors to the console instead of using user-friendly messages or retry mechanisms. Try contacting @lhenze and asking her about UI expectations when fetch fails.
Comments: Add comments to the code. This is a suggestion since we don't have a document describing how to document our work.
This is the beginning of adding Geospatial functionality to UltraViolet.
This PR includes the following functionality/features:
Addresses #209, #210, #211 and #212
Note: I'd prefer to squash this before merging it, so I'd like to merge it myself once it's approved.
Screenshots
Custom Fields Editing
Restricted Record
Public Record