Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #556

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

grantmx
Copy link

@grantmx grantmx commented Jan 2, 2025

Adding htmlTitle to the documentation so that the title attribute on the button element could be populated. This feature is needed to improve CORE Web Vitals accessibility and we didn't realize this was a part of the component until we made a deep dive in to the code.

Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: db96dda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cwlowder
Copy link

cwlowder commented Jan 6, 2025

@grantmx since it can take a while for PRs to be approved, I recommend adding the changeset now so we can unblock this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants