-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GH action to build an artifact for map.nycmesh.net #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-Dickinson
force-pushed
the
andrew/map-builds
branch
13 times, most recently
from
November 9, 2024 21:53
296a5fd
to
e67b0b8
Compare
Andrew-Dickinson
force-pushed
the
andrew/map-builds
branch
from
November 9, 2024 21:56
e67b0b8
to
972da1a
Compare
Andrew-Dickinson
force-pushed
the
andrew/map-builds
branch
2 times, most recently
from
November 9, 2024 21:59
eecaebc
to
6a517c2
Compare
LydonThorpe
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URLs look good. Can't comment on the code as that's out of my knowledge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a github action which builds an artifact specifically for map.nycmesh.net
Doing the build here ensures we're kept up to date with the latest website format changes and we always look identical in the subdomain
Also converts all URLs on the map page to absolute URLs so that when we move where that page is hosted, the links all still work