Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action to build an artifact for map.nycmesh.net #164

Merged
merged 18 commits into from
Nov 10, 2024

Conversation

Andrew-Dickinson
Copy link
Member

@Andrew-Dickinson Andrew-Dickinson commented Nov 9, 2024

Add a github action which builds an artifact specifically for map.nycmesh.net

Doing the build here ensures we're kept up to date with the latest website format changes and we always look identical in the subdomain

Also converts all URLs on the map page to absolute URLs so that when we move where that page is hosted, the links all still work

@Andrew-Dickinson Andrew-Dickinson force-pushed the andrew/map-builds branch 13 times, most recently from 296a5fd to e67b0b8 Compare November 9, 2024 21:53
@Andrew-Dickinson Andrew-Dickinson force-pushed the andrew/map-builds branch 2 times, most recently from eecaebc to 6a517c2 Compare November 9, 2024 21:59
@Andrew-Dickinson Andrew-Dickinson marked this pull request as ready for review November 9, 2024 22:09
Copy link
Collaborator

@LydonThorpe LydonThorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs look good. Can't comment on the code as that's out of my knowledge

@Andrew-Dickinson Andrew-Dickinson merged commit bc16be5 into master Nov 10, 2024
4 checks passed
@Andrew-Dickinson Andrew-Dickinson deleted the andrew/map-builds branch November 10, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants