-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hackathons section #83
Conversation
Visit the preview URL for this PR (updated for commit ac43843): https://nwplus-io--pr83-kevin-30-wvcrgdb4.web.app (expires Mon, 06 Sep 2021 07:47:34 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aside from the nits with the constants, it looks superb!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🙏🙏👏👏👏👏
Description
Resolves #30. This PR adds the hackathon section to the landing page, complete with photos and some placeholder text.
I refactored the styling in the
HackathonCard
component since it had some weird behaviour on hover. It would show the image for the last hackathon (ie. cmd-f) regardless of which hackathon you were hovering. This was probably because the selector on line 19 (in the original code) came back with 3 options (as there are 3CardContainer
s) and just gave back the last one by default (cmd-f).Stop using ThemeContext
I realized that I don't always need to use ThemeContext to fetch theme properties, and therefore I do not need to declare
styled
components within the component function. I think this has been messing up the styling when statically exporting the site with Next.js, so let's see if this fixes it. Regardless this cleans up the code!Other considerations
LinkBody
typography component, @vincentchiang1 lmk if this is okay