Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hackathons section #83

Merged
merged 7 commits into from
Aug 30, 2021
Merged

Add hackathons section #83

merged 7 commits into from
Aug 30, 2021

Conversation

kevin-zou
Copy link
Contributor

@kevin-zou kevin-zou commented Aug 29, 2021

Description

Resolves #30. This PR adds the hackathon section to the landing page, complete with photos and some placeholder text.

I refactored the styling in the HackathonCard component since it had some weird behaviour on hover. It would show the image for the last hackathon (ie. cmd-f) regardless of which hackathon you were hovering. This was probably because the selector on line 19 (in the original code) came back with 3 options (as there are 3 CardContainers) and just gave back the last one by default (cmd-f).

Stop using ThemeContext

I realized that I don't always need to use ThemeContext to fetch theme properties, and therefore I do not need to declare styled components within the component function. I think this has been messing up the styling when statically exporting the site with Next.js, so let's see if this fixes it. Regardless this cleans up the code!

Other considerations

  • refactored a bit of the Resources component after making some changes to the LinkBody typography component, @vincentchiang1 lmk if this is okay
  • this doesn't have the star in the background, it was hard to implement and I think I went about it the wrong way - going to open an issue to come back to this and the other section backgrounds I've already done (Nit: section background trinkets not complete #84)

@kevin-zou kevin-zou requested review from vincentchiang1, andykwan1124 and a team August 29, 2021 20:19
@github-actions
Copy link

github-actions bot commented Aug 29, 2021

Visit the preview URL for this PR (updated for commit ac43843):

https://nwplus-io--pr83-kevin-30-wvcrgdb4.web.app

(expires Mon, 06 Sep 2021 07:47:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Contributor

@vincentchiang1 vincentchiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aside from the nits with the constants, it looks superb!

components/Hackathons.js Outdated Show resolved Hide resolved
components/Hackathons.js Outdated Show resolved Hide resolved
Copy link
Contributor

@panjenny0 panjenny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🙏🙏👏👏👏👏

@kevin-zou kevin-zou merged commit 9100056 into main Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hackathons > Container (desktop + mobile)
3 participants