Modify application scoring to store last updated metadata by question #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e861945): https://nw-admin-portal--pr284-daniel-last-updated-gr3rm31r.web.app (expires Mon, 16 Dec 2024 04:21:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e |
daniel-panhead
force-pushed
the
daniel/last-updated-by-question
branch
from
8fc9300 to
63b8d9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New schema for storing scores:
Instead of each app question being mapped directly to a score, it is mapped to an object containing store + last updated metadata
Other considerations
This change definitely breaks the /assessment endpoint since it modifies an underlying function used by both, but considering the page looks broken already, we should be fine :)
This PR also modifies a global firebase setting - setting/updating now ignores undefined values where previously it would error.