Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Checkbox and File Upload question types, some logic changes #251

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

tdanielles
Copy link
Contributor

@tdanielles tdanielles commented Aug 18, 2024

Description

  • remove 'File Upload' and 'Checkbox' question types since checkboxes remain hardcoded in Portal and there is now a 'Portfolio' question type for resume uploads
  • changed logic for better UX for the formInput dropdown
  • remove ability to select portfolio type for basic info section and ability to select major, school, country, and legal name types in skills section
  • added Questionnaire section
  • added validation such that users can't save a section when one of the questions doesn't have a formInput field

@tdanielles tdanielles changed the base branch from main to dev August 18, 2024 23:50
Copy link

github-actions bot commented Aug 18, 2024

Visit the preview URL for this PR (updated for commit 561005e):

https://nw-admin-portal--pr251-form-builder-edits-08dqouh1.web.app

(expires Sun, 01 Sep 2024 09:51:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@tdanielles tdanielles requested a review from martincai8 August 19, 2024 00:00
@tdanielles tdanielles marked this pull request as ready for review August 19, 2024 00:00
…chool from skills
Copy link
Contributor

@martincai8 martincai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 🚀

components/questionCard.js Outdated Show resolved Hide resolved
@tdanielles tdanielles merged commit faad792 into dev Aug 26, 2024
2 checks passed
@tdanielles tdanielles deleted the form-builder-edits branch August 26, 2024 23:19
tdanielles added a commit that referenced this pull request Sep 28, 2024
* implemented sidebar and routing

* fix bug

* added general structure and formatting

* implemented welcome page

* draft question component

* janky (but working) code for form

* fix linting

* restore yarn.lock for now

* add yarn.lock back

* styled components pro max + named export for hacker app navbar

* addressed the rest of the comments

* added save button that does absolutely nothing

* fix linting?

* fixed linting fr this time LOL

* addressed comment

* move save btn + added firebase get and save for skills and basic info

* welcome db connect + resolve some warnings

* clean up

* more cleanup

* add lasteditedby and lastedited at

* await handleSave and added padding

* Add form input dropdown (#249)

* initial push

* added major and form input dropdown

* greyed out when selected

* CMS form builder additions (#250)

* Add Questionnaire section, remove Checkbox and File Upload question types, logic and validation changes (#251)

* remove checkbox, fileupload, and edit logic for formInput

* fix linting issues?

* remove portfolio type from basic info and country, major, name, and school from skills

* add questionnaire section and formInput validation when saving

* final

* final + tested

* fix linting

* bring the hacker apps section of the sidebar back

* remove package-lock

* fix lint error

* run ci on PRs to dev

---------

Co-authored-by: tdanielles <[email protected]>
Co-authored-by: martincai8 <[email protected]>
Co-authored-by: Martin Cai <[email protected]>
Co-authored-by: trisha <[email protected]>
Co-authored-by: jkuo630 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants