-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Checkbox and File Upload question types, some logic changes #251
Merged
+309
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 561005e): https://nw-admin-portal--pr251-form-builder-edits-08dqouh1.web.app (expires Sun, 01 Sep 2024 09:51:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e |
Loading status checks…
…chool from skills
martincai8
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ship it 🚀
Loading status checks…
martincai8
approved these changes
Aug 26, 2024
tdanielles
added a commit
that referenced
this pull request
Sep 28, 2024
* implemented sidebar and routing * fix bug * added general structure and formatting * implemented welcome page * draft question component * janky (but working) code for form * fix linting * restore yarn.lock for now * add yarn.lock back * styled components pro max + named export for hacker app navbar * addressed the rest of the comments * added save button that does absolutely nothing * fix linting? * fixed linting fr this time LOL * addressed comment * move save btn + added firebase get and save for skills and basic info * welcome db connect + resolve some warnings * clean up * more cleanup * add lasteditedby and lastedited at * await handleSave and added padding * Add form input dropdown (#249) * initial push * added major and form input dropdown * greyed out when selected * CMS form builder additions (#250) * Add Questionnaire section, remove Checkbox and File Upload question types, logic and validation changes (#251) * remove checkbox, fileupload, and edit logic for formInput * fix linting issues? * remove portfolio type from basic info and country, major, name, and school from skills * add questionnaire section and formInput validation when saving * final * final + tested * fix linting * bring the hacker apps section of the sidebar back * remove package-lock * fix lint error * run ci on PRs to dev --------- Co-authored-by: tdanielles <[email protected]> Co-authored-by: martincai8 <[email protected]> Co-authored-by: Martin Cai <[email protected]> Co-authored-by: trisha <[email protected]> Co-authored-by: jkuo630 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description