-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect hacker app form to firebase #248
Conversation
Visit the preview URL for this PR (updated for commit eeba4a7): https://nw-admin-portal--pr248-firebase-hacker-app-2tjqd14h.web.app (expires Wed, 07 Aug 2024 20:58:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THIS LOOKS REALLY GOOD!! 🐐
Minor things to keep in mind (these don't need to be implemented right away):
opening the drop down extends the page, perhaps we could add a scroll bar to the dropdown, or do margin-bottom: (height of the dropdown) to the last question so this wouldn't happen
i believe we discussed having an auto-save or reminder pop up for users who forget to save, having this would be a nice addition (i forgot to save after adding my questions, since the save button was all the way at the top)
but no need to implement these rn, i'd prioritize more urgent tickets, we can save these til the end since this is an internal tool! :)
Description
Ticket: https://www.notion.so/nwplus/PA-12-Link-CMS-and-Portal-questions-via-Firebase-a1189899f50a4b8d8d963ea20587bdc2?pvs=4