Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect hacker app form to firebase #248

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Connect hacker app form to firebase #248

merged 6 commits into from
Aug 1, 2024

Conversation

tdanielles
Copy link
Contributor

@tdanielles tdanielles commented Jul 29, 2024

Description

Ticket: https://www.notion.so/nwplus/PA-12-Link-CMS-and-Portal-questions-via-Firebase-a1189899f50a4b8d8d963ea20587bdc2?pvs=4

  • moved save btn from page to the subpages
  • connected to firebase in 'HackerAppQuestions' collection
  • docs within the collection named as 'HackCamp', 'nwHacks', and 'cmd-f' for now since I believe the discussion was to just have the 3 current hackathons on the database and not store previous years' questions
  • loading and saving should work (in dev)
  • currently it is clearing and then saving all at the same time per category (e.g. basic info, welcome, skills) bc i think that's how it was in the figma - lmk if you guys think it's better to have a save/delete per question or if that won't be a problem since there'll probably be less than 10 questions per category

@tdanielles tdanielles changed the base branch from main to dev July 29, 2024 00:28
Copy link

github-actions bot commented Jul 29, 2024

Visit the preview URL for this PR (updated for commit eeba4a7):

https://nw-admin-portal--pr248-firebase-hacker-app-2tjqd14h.web.app

(expires Wed, 07 Aug 2024 20:58:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

@tdanielles tdanielles assigned tdanielles and unassigned tdanielles Jul 29, 2024
@tdanielles tdanielles marked this pull request as ready for review July 29, 2024 02:04
@tdanielles tdanielles changed the title Firebase hacker app Connect hacker app form to firebase Jul 29, 2024
Copy link
Contributor

@martincai8 martincai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so smart 🧠 left some small comments but lgtm otherwise 😮‍💨

pages/hackerapps/[id]/basicinfo.js Outdated Show resolved Hide resolved
utility/firebase.js Show resolved Hide resolved
utility/firebase.js Outdated Show resolved Hide resolved
Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS LOOKS REALLY GOOD!! 🐐

Minor things to keep in mind (these don't need to be implemented right away):
opening the drop down extends the page, perhaps we could add a scroll bar to the dropdown, or do margin-bottom: (height of the dropdown) to the last question so this wouldn't happen
image

i believe we discussed having an auto-save or reminder pop up for users who forget to save, having this would be a nice addition (i forgot to save after adding my questions, since the save button was all the way at the top)

but no need to implement these rn, i'd prioritize more urgent tickets, we can save these til the end since this is an internal tool! :)

@tdanielles
Copy link
Contributor Author

THIS LOOKS REALLY GOOD!! 🐐

Minor things to keep in mind (these don't need to be implemented right away): opening the drop down extends the page, perhaps we could add a scroll bar to the dropdown, or do margin-bottom: (height of the dropdown) to the last question so this wouldn't happen image

i believe we discussed having an auto-save or reminder pop up for users who forget to save, having this would be a nice addition (i forgot to save after adding my questions, since the save button was all the way at the top)

but no need to implement these rn, i'd prioritize more urgent tickets, we can save these til the end since this is an internal tool! :)

Ok sounds good! Will add those to the action items and work on them after I finish the portal side of things ^^

@tdanielles tdanielles merged commit 99dc36f into dev Aug 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants