Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package-lock.json #247

Merged
merged 2 commits into from
Jul 21, 2024
Merged

Remove package-lock.json #247

merged 2 commits into from
Jul 21, 2024

Conversation

martincai8
Copy link
Contributor

@martincai8 martincai8 commented Jul 19, 2024

image

Description

Removing package-lock.json in favour of yarn.lock since it's being used already for firebase deployments

Copy link

github-actions bot commented Jul 19, 2024

Visit the preview URL for this PR (updated for commit b0d9e53):

https://nw-admin-portal--pr247-npm-to-yarn-jydj8rs0.web.app

(expires Sat, 27 Jul 2024 23:56:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! seems like there are linting issues, but you can fix it all later

@DonaldKLee
Copy link
Member

lgtm! seems like there are linting issues, but you can fix it all later

oh wait this isn't for portal, can we fix linting issues?

@martincai8
Copy link
Contributor Author

martincai8 commented Jul 20, 2024

lgtm! seems like there are linting issues, but you can fix it all later

oh wait this isn't for portal, can we fix linting issues?

wait where are the linting issues LOL are you talking about the warnings

@martincai8 martincai8 merged commit b0f848f into main Jul 21, 2024
5 checks passed
@martincai8 martincai8 deleted the npm-to-yarn branch July 21, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants