Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Hacker Application Form #246

Merged
merged 6 commits into from
Jul 28, 2024
Merged

CMS Hacker Application Form #246

merged 6 commits into from
Jul 28, 2024

Conversation

tdanielles
Copy link
Contributor

@tdanielles tdanielles commented Jul 16, 2024

Description

Ticket: https://www.notion.so/nwplus/PA-11-Create-form-on-CMS-admin-7ab9b14ce64945b9b599d8ecd1825dd3?pvs=4

  • Added form builder to CMS for the 3 hackathons
  • Nothing saves to the database or anywhere yet, but all other functionalities (add, copy, switch, toggle) should work!
  • Please hunt for any bugs 😀
  • Also VERY open to any code optimizations (will also take a look and optimize as i go)
  • Also aware of the linting stuff (will fix)

Copy link

github-actions bot commented Jul 16, 2024

Visit the preview URL for this PR (updated for commit 87f13ac):

https://nw-admin-portal--pr246-hacker-app-form-05qhkx2d.web.app

(expires Sun, 04 Aug 2024 03:13:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

@tdanielles tdanielles marked this pull request as ready for review July 16, 2024 07:02
@tdanielles tdanielles added the enhancement New feature or request label Jul 16, 2024
Copy link
Contributor

@martincai8 martincai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goated PR you're so cracked

app.css Outdated Show resolved Hide resolved
components/hackerAppNavbar.js Outdated Show resolved Hide resolved
components/page.js Outdated Show resolved Hide resolved
components/questionCard.js Outdated Show resolved Hide resolved
components/questionCard.js Outdated Show resolved Hide resolved
components/questionDropdown.js Outdated Show resolved Hide resolved
components/questionDropdown.js Outdated Show resolved Hide resolved
components/questionDropdown.js Outdated Show resolved Hide resolved
pages/hackerapps/[id]/basicinfo.js Outdated Show resolved Hide resolved
pages/hackerapps/[id]/basicinfo.js Outdated Show resolved Hide resolved
Copy link
Member

@DonaldKLee DonaldKLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks fire!! Great job! Minor changes: convert styles to styled components for consistency

EDIT:
when I edit the welcome section forms, and click on another hackathon, the changes are carried over. will this be fixed after we implement the save functions?

app.css Outdated Show resolved Hide resolved
components/questionCard.js Outdated Show resolved Hide resolved
pages/hackerapps/[id]/welcome.js Outdated Show resolved Hide resolved
@DonaldKLee DonaldKLee requested a review from joannelex July 21, 2024 07:44
Copy link
Contributor

@martincai8 martincai8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdanielles
Copy link
Contributor Author

UI looks fire!! Great job! Minor changes: convert styles to styled components for consistency

EDIT: when I edit the welcome section forms, and click on another hackathon, the changes are carried over. will this be fixed after we implement the save functions?

@DonaldKLee yes that would be fixed after saves are implemented and the questions are linked to firebase

@tdanielles tdanielles closed this Jul 23, 2024
@tdanielles tdanielles reopened this Jul 23, 2024
@tdanielles tdanielles changed the base branch from main to dev July 28, 2024 01:06
@martincai8 martincai8 merged commit 4dd3da2 into dev Jul 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants