Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table swap issues, add meal data #235

Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix table swap issues, add meal data #235

merged 2 commits into from
Feb 29, 2024

Conversation

alvinkam33
Copy link
Contributor

added meal data (yes/no) for day 1 and day 2 breakfast, lunch, dinner
though timestamps are stored in an array, this is assumed to be a duplicate scan (e.g. dont think someone should have lunch twice?)

@alvinkam33 alvinkam33 requested a review from meleongg February 25, 2024 23:39
Copy link

github-actions bot commented Feb 25, 2024

Visit the preview URL for this PR (updated for commit eed0d0a):

https://nw-admin-portal--pr235-query-fixes-e08ntzq7.web.app

(expires Tue, 05 Mar 2024 08:05:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

@meleongg
Copy link
Member

  • double meal info is prolly the result of a double scan OR if hackers grabbed seconds at a meal or something
  • some of the firebase fields were updated as a result of cmd-f 2024 updating their hacker questions (e.g. legalFirstName vs firstName), which might break some of the hacker data querying

@alvinkam33
Copy link
Contributor Author

  • changed meal info to show count instead; if potential double scans want to be ignored user can use the count function rather than sum after filtering out 0's. unfortunately i think this is the best we can do
  • i checked the new fields like legalFirstName and legalLastName and they all seem to work fine 👍

@meleongg meleongg merged commit 6980ea2 into main Feb 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants