Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmd f evaluator #234

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Cmd f evaluator #234

merged 5 commits into from
Feb 26, 2024

Conversation

alvinkam33
Copy link
Contributor

Notes:

  • changed long answers to match portal (just first 3)
  • changed longAnswer3 to 3 points, added minus 1 option (total score 15)
  • filtered applicants out from evaluator if they answered 'no' to underrepresented (couldn't use firebase where because it only allows one inequality clause on a single field lol)
  • changed sort comparison to use legalFirstName (assuming firstName is deprecated from now on)

@alvinkam33 alvinkam33 requested a review from meleongg February 25, 2024 01:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 25, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit fc4a82e):

https://nw-admin-portal--pr234-cmd-f-evaluator-5rzmlvrp.web.app

(expires Sun, 03 Mar 2024 23:22:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e

meleongg
meleongg reviewed Feb 25, 2024
View reviewed changes
utility/firebase.js Outdated
Comment on lines 576 to 577
.filter(a => a.basicInfo.identifyAsUnderrepresented !== 'no') // cmd-f filter; remove after
.sort((a, b) => a.basicInfo.legalFirstName.localeCompare(b.basicInfo.legalFirstName))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need a stronger/alternative sort here (like also add last name as secondary sort) since we ran into problems with nwHacks where some applicant placements kept jumping if they had the same first name before/after they were graded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok added last name sort

@meleongg
Copy link
Member

in firebase.js, you'll also need to switch the active hackathon from nwHacks2024 to cmd-f2024

@alvinkam33
Copy link
Contributor Author

in firebase.js, you'll also need to switch the active hackathon from nwHacks2024 to cmd-f2024

i think this should have alr been done? i searched the code and there's no other place to switch active hackathon

@alvinkam33 alvinkam33 requested a review from meleongg February 25, 2024 22:43
meleongg
meleongg approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@meleongg meleongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for being speedy with it

@meleongg meleongg merged commit 7f4312c into main Feb 26, 2024
5 checks passed
@meleongg meleongg deleted the cmd-f_evaluator branch February 26, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meleongg meleongg meleongg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvinkam33 @meleongg