Anonymize evaluator applicant info for nwHacks 2024 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 52b6527): https://nw-admin-portal--pr227-anonymize-evaluator-4lwq1xf6.web.app (expires Fri, 29 Dec 2023 06:01:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d819f9eb3b1b79c03e9109f08eeff92215a2990e |
meleongg
changed the title
michelleykim
approved these changes
Dec 17, 2023
|
It still returns the anonymous entries based on inputting name or email in the search bar https://github.com/nwplus/admin/blob/anonymize-evaluator/components/Evaluator/HackerList.js#L94 is this a desirable feature? from basic testing, it works for all applicants who are not status (inProgress) |
|
@michelleykim I talked to Alan and he said that searching by name/email could still be useful too so I just added a lil instructions paragraph elm saying what the search actually does 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Other considerations
/assessment(the predecessor of the current/evalpage) endpoint can't be reached to test the old acceptance button