Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add new Indic languages #740

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WIP: Add new Indic languages #740

wants to merge 4 commits into from

Conversation

nvkelso
Copy link
Owner

@nvkelso nvkelso commented May 26, 2022 •
edited
Loading

Evoke like:

python3 ./tools/wikidata/fetch_wikidata.py -input_lettercase uppercase -input_shape_name 10m_cultural/ne_10m_populated_places.shp -output_csv_name x_tempshape/ne_10m_populated_places.new_names.csv

  • name_gu
  • name_kn
  • name_ml
  • name_mr
  • name_pa
  • name_ta
  • name_te
  • name_th

@nvkelso
Copy link
Owner Author

nvkelso commented May 26, 2022

cc @jeffdefacto

junderwood added 3 commits May 31, 2022 11:27
alphabetized languages in fetch_wikidata.py
4d744b8 
added additional language support to write_wikidata.py

Added fix for arabic and Chinese/Japanese commas
Added ideographic comma
5a5f73e
add arg to allow/disallow overwriting existing rows
5623328
@nvkelso
Copy link
Owner Author

nvkelso commented Jun 14, 2022

This looks good, let's look at the fill rates and coordinate backfilling the rest before merging – since we may need to run the existing languages again before the backfill comes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nvkelso