Enhance open_online action #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conni2461
reviewed
Jan 6, 2023
lua/telescope/_extensions/packer.lua
Outdated
| local function get_url(path) | ||
| local url = vim.fn.trim(vim.fn.system(string.format("git -C %s ls-remote --get-url", path))) | ||
| if string.sub(url, 1, 6) == 'ssh://' then | ||
| url, _ = string.gsub(url, [[^ssh://[^/]+/]], 'https://github.com/') |
There was a problem hiding this comment.
not every ssh:// points to github.com, we can actually get the real url from that
There was a problem hiding this comment.
e.g. if we have
local url = "ssh://[email protected]:gitlab-org/gitlab.git"
url = string.gsub(url, [[^ssh://[^/]+/]], 'https://github.com/')
print(url)
i would expect https://gitlab.com/gitlab-org/gitlab but i currently get https://github.com/gitlab.git which is completely wrong
Conni2461
reviewed
Feb 19, 2023
Comment on lines
+50
to
+53
| if string.sub(url, 1, 6) == 'ssh://' then | ||
| url, _ = string.gsub(url, '^ssh://%w+@', 'https://') | ||
| url, _ = string.gsub(url, '^ssh://', 'https://') | ||
| end |
There was a problem hiding this comment.
oh one more thing it could also start with [email protected]:nvim-telescope/telescope.nvim.git e.g.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request will resolve:
open_onlineaction does not support ssh:// remote url. (open_online action does not work #21)open_onlineaction does not support WSL. ("Open online repository" never works in the WSL #24)@Conni2461 Review and merge it plz.