Add pre_filter_speechSequence and post_filter_speechSequence extension point Actions #17429
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nPoint Actions, inject pre_filter_speechSequence just before filter in speech.speak and use post_filter_speechSequence in speechViewer as @LeonarddeR stated in nvaccess#14520
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Superseeds #16213
Summary of the issue:
Add pre_filter_speechSequence and post_filter_speechSequence extensionPoint Actions, inject pre_filter_speechSequence just before filter in speech.speak and use post_filter_speechSequence in speechViewer as @LeonarddeR stated in #14520
Description of user facing changes
Nothing changed from user's point of view
Description of development approach
Removed code responsible for appending speechSequence to speech_viewer from speech.speak and registered appendSpeechSequence as extensionPoint handler function.
Testing strategy:
Manually tested that speech is still visible on the screen when activating speech_viewer
Known issues with pull request:
None at this moment
Code Review Checklist:
@coderabbitai summary