Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Thrust to the latest version #802

Closed
wants to merge 2 commits into from

Conversation

marcinz
Copy link
Collaborator

@marcinz marcinz commented Jul 26, 2023

This update will have impact on the CTK requirement. There is be a corresponding cunumeric PR to test the impact of the update on cunumeric: nv-legate/cupynumeric#1006

@marcinz marcinz added the category:improvement PR introduces an improvement and will be classified as such in release notes label Jul 26, 2023
@marcinz marcinz requested review from magnatelee and manopapad July 26, 2023 09:55
@manopapad
Copy link
Contributor

I think we can stick to thrust 1.17 for now, and avoid having to bump our minimum CTK version. It appears that thrust is moving towards a model where thrust, cub and libcu++ are distributed together, and don't depend on specific CTK versions. Once https://github.com/nvidia/cccl and the corresponding conda package https://anaconda.org/conda-forge/cuda-cccl-impl are mature we can switch to those.

@marcinz
Copy link
Collaborator Author

marcinz commented Aug 23, 2023

Rapids cmake has been updated for the new Thrust: rapidsai/rapids-cmake#399

They apply quite a few patches and install their own libcudacxx. I will check if that works with the older CTK.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 30, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@marcinz
Copy link
Collaborator Author

marcinz commented Aug 30, 2023

/ok to test

@marcinz marcinz changed the base branch from branch-23.09 to branch-23.11 September 26, 2023 00:22
@marcinz marcinz changed the base branch from branch-23.11 to branch-24.01 November 9, 2023 16:51
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 00:53
@marcinz marcinz closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:improvement PR introduces an improvement and will be classified as such in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants