DRAFT: Add suggested fixes for known build issues #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjwilke
added
the
category:improvement
jjwilke
changed the title
|
This needs to be changed to both capture output and continue to pipe output to the terminal. I don't recall an easy way to do this with Python. |
bryevdv
reviewed
Sep 22, 2022
| OKGREEN = "\033[92m" | ||
| WARNING = "\033[93m" | ||
| FAIL = "\033[91m" | ||
| ENDC = "\033[0m" |
There was a problem hiding this comment.
Could imitate the API I've used elsewhere for consistency
(just manually, w/o using colorama)
|
@jjwilke it seems non-trivial enough that there is an entire package for doing it https://github.com/pycontribs/subprocess-tee Maybe we could simplify it and vendor the parts we need. Otherwise, you can capture stdout and then just print it back out yourself, but obviously that won't update the console "in real time" |
bryevdv
previously approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.