Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
While a less-known optimization, pre-allocating arrays allows the JavaScript engine to prepare all the memory upfront for the array and prevent dynamic resizing. Directly accessing arrays would be O(1) as opposed to
Array.prototype.push
being amortized O(1) due to the occasional dynamic resizing which is O(n).This PR, while having the pre-allocated arrays as the core change, simplifies affected areas by, for example, reducing iteration and mapping counts for arrays whose size can be determined immediately, and thus can be pre-allocated. By doing that, in areas with multiple arrays (such as the CSS plugin that registers the initial root variables), we can use a single loop and consolidate the mapping logic directly in it.
π Checklist