Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Alert): remove description line height not to override ui props #2555

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

offich
Copy link

@offich offich commented Nov 7, 2024

πŸ”— Linked issue

Resolves: #2554

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@offich offich changed the title chore: remove line height not to override [UAlert] remove description line height not to override Nov 7, 2024
@offich offich changed the title [UAlert] remove description line height not to override fix(UAlert): remove description line height not to override Nov 7, 2024
@offich offich changed the title fix(UAlert): remove description line height not to override fix(UAlert): remove description line height not to override ui props Nov 7, 2024
@offich offich changed the title fix(UAlert): remove description line height not to override ui props fix(Alert): remove description line height not to override ui props Nov 7, 2024
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the alignment if you remove the leading-5 since it is by default set to leading-4. We should split the ui.description in two instead.

@offich
Copy link
Author

offich commented Nov 11, 2024

@benjamincanac Thanks you for your review! I tried to find a new ui config key when I split ui.description, but I could not come up with it. So I ended up moving the current classes for description into ui default key-value. I would like to hear your option again.

@offich offich requested a review from benjamincanac November 11, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

【UAlert】Unable to change line height for description when only description slot gets passed
2 participants