-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: explicit async loading #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #212 +/- ##
==========================================
+ Coverage 86.04% 86.28% +0.23%
==========================================
Files 7 7
Lines 172 175 +3
Branches 39 41 +2
==========================================
+ Hits 148 151 +3
Misses 24 24
Continue to review full report at Codecov.
|
pi0
changed the title
feat: explicit lazy loading by component names
feat: explicit lazy loading
Jul 8, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By this change, during development, all components are imported without async loading to be the same as prod loader (resolves #193)
.async
modifier to component names (BigEditor.async.vue
)async
tofalse
components: { isAsync: true }
)Generated
components/index.js
dev: (same as the expected loader behavior)
prod: (fallback when the loader is not matching)
TODO
.async
suffix in loader