fix: fix find of undefined error #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting same error on my side after upgrade to Nuxt 2.15.8 |
mazemax
approved these changes
Sep 23, 2022
|
I don't have write permission, sorry :/ |
rchl
reviewed
Sep 23, 2022
Comment on lines
+35
to
+44
| const head = typeof ctx.app.head === 'function' ? ctx.app.head() : ctx.app.head; | ||
|
|
||
| const gtmScript = head.script.find(s => s.hid == '<%= options.scriptId %>') | ||
| gtmScript.innerHTML = `window['${_layer}']=${JSON.stringify(events)};${gtmScript.innerHTML}` | ||
|
|
||
| if (inits.length) { | ||
| gtmScript.innerHTML += `;${JSON.stringify(inits)}.forEach(function(i){window._gtm_inject(i)})` | ||
| } | ||
| <% if (options.noscript) { %> | ||
| const gtmIframe = ctx.app.head.noscript.find(s => s.hid == '<%= options.noscriptId %>') | ||
| const gtmIframe = head.noscript.find(s => s.hid == '<%= options.noscriptId %>') |
There was a problem hiding this comment.
This is not a correct fix. The intention of the original code was to modify the innerHTML of the script added to head. When head is a function you can't modify the original script as your will (most likely) receive a new head object every time the function is called.
So this change will prevent the crash while at the same time make this part of the code not do anything useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some combinations(maybe with @nuxtsj/compositions-api?) app.head is a function instead of object which leads to an error
#141