Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: run clippy and fix issues #58

Closed
wants to merge 1 commit into from

Conversation

jaudiger
Copy link

Hello there, it's quite a while the last time I opened a PR here. This time I just ran clippy in the examples folder, and resolved the issues that were reported.

Please let me know if you don't want this PR as is.

@fdncred
Copy link

fdncred commented May 17, 2024

Let's think about it because this crate is a pain to update for nushell because we publish a new version, then we have to wait for lscolors to publish a new version, then we have to wait for reedline, and then finally we can use it in nushell. So, if it's not significant changes, I'm inclined to just wait on this until the next significant change.

@jaudiger
Copy link
Author

Sure, I understand. I did open one last PR (#59) but on the source folder this time. It has the advantages to derive few must_use macro. But I'm opened to updating both PR if needed, of course.

@kubouch
Copy link

kubouch commented Jun 29, 2024

When I run cargo clippy in the examples/ folder, nothing shows up.

@jaudiger jaudiger closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants