Code

nu-ansi-term overhaul#53

Code

Closed

bzm3r wants to merge 62 commits intonushell:mainnushell/nu-ansi-term:mainfrom bzm3r:mainbzm3r/nu-ansi-term:mainCopy head branch name to clipboard

+2,273-1,156

Commits

Commits on Oct 4, 2023

• Creating macros as replacement for write! that are AnyWrite aware. This

  Show description for a14625d
  

  Brian Merchant

  committed
  a14625d

  Copy full SHA for a14625d

• Fix a minor warning that has an auto-fix, in an example.

  

  Brian Merchant

  committed
  f960695

  Copy full SHA for f960695

• Content is now working.

  

  Brian Merchant

  committed
  04d54de

  Copy full SHA for 04d54de

• Content is now working

  

  Brian Merchant

  committed
  d0629c5

  Copy full SHA for d0629c5

• Rename Content to Writeable; making some attempts to allow String to be Writeable

  

  Brian Merchant

  committed
  ceabbca

  Copy full SHA for ceabbca

• Use WriteResult to clean up noise.

  

  Brian Merchant

  committed
  006aa10

  Copy full SHA for 006aa10

• Issues with plurals not being able to accept multiple types as per their

  Show description for c55405b
  

  Brian Merchant

  committed
  c55405b

  Copy full SHA for c55405b

Commits on Oct 5, 2023

• Everything finally compiles.

  

  Brian Merchant

  committed
  6c7f33b

  Copy full SHA for 6c7f33b

• All tests pass, except for unimplemented ones that use plural functionality.

  

  Brian Merchant

  committed
  132014c

  Copy full SHA for 132014c

• Implemented new incremental update of styles.

  

  Brian Merchant

  committed
  9f5cd78

  Copy full SHA for 9f5cd78

• Updated tests in difference.rs

  

  Brian Merchant

  committed
  99e4b7e

  Copy full SHA for 99e4b7e

• Undo changes done by mistake to selected ranges of write.rs

  

  Brian Merchant

  committed
  8550239

  Copy full SHA for 8550239

• More fixes.

  

  Brian Merchant

  committed
  984e444

  Copy full SHA for 984e444

• Plural strings implemented.

  

  Brian Merchant

  committed
  dbdd0c7

  Copy full SHA for dbdd0c7

• Addressing test fails.

  

  Brian Merchant

  committed
  8d044dd

  Copy full SHA for 8d044dd

Commits on Oct 6, 2023

• Trying to figure out why reset is not being printed correctly.

  

  Brian Merchant

  committed
  515bac1

  Copy full SHA for 515bac1

• Using bitflags for Style

  

  Brian Merchant

  committed
  1ca0931

  Copy full SHA for 1ca0931

Commits on Oct 7, 2023

• Re-implemented tests.

  

  Brian Merchant

  committed
  bfab51f

  Copy full SHA for bfab51f

Commits on Oct 8, 2023

• All non-doc tests are passing.

  

  Brian Merchant

  committed
  2b4dfe3

  Copy full SHA for 2b4dfe3

Commits on Oct 9, 2023

• All tests (including doc tests) for not(gnu_legacy) are passing.

  

  Brian Merchant

  committed
  af866e5

  Copy full SHA for af866e5

• All gnu_legacy tests are also passing now.

  

  Brian Merchant

  committed
  9b0bdc5

  Copy full SHA for 9b0bdc5

• Write documentation.

  

  Brian Merchant

  committed
  baa2da6

  Copy full SHA for baa2da6

• Remove unnecssary content_from! macro, which is not needed because we no longer need to specifically implement From<T> for Content for a wide variety of different T

  

  Brian Merchant

  committed
  7b29684

  Copy full SHA for 7b29684

• Don't use bitflags for prefix_with_reset and coloring.

  

  Brian Merchant

  committed
  9b2b298

  Copy full SHA for 9b2b298

• Allowing AnsiGenericStrings to use Cow in order to mitigate cloning costs; however, now we have lifetime errors we must be careful about.

  

  Brian Merchant

  committed
  2d9358f

  Copy full SHA for 2d9358f

• making some progress on lifetimes

  

  Brian Merchant

  committed
  091871a

  Copy full SHA for 091871a

• lifetimes work now

  

  Brian Merchant

  committed
  5f43162

  Copy full SHA for 5f43162

• Change AnsiGenericStrings so that it just holds AnsiGenericString instances, rather than separating it out into content/oscontrol/styles.

  

  Brian Merchant

  committed
  1562a75

  Copy full SHA for 1562a75

• wip

  

  Brian Merchant

  committed
  9334e60

  Copy full SHA for 9334e60

Commits on Oct 10, 2023

• Allow updating of styles.

  

  Brian Merchant

  committed
  ddadb46

  Copy full SHA for ddadb46

• Looks like a proc_macro is needed to create the ansi_generics! macro.

  

  Brian Merchant

  committed
  b62a2f4

  Copy full SHA for b62a2f4

• Initializing creation of ansi_generics_macro.

  

  Brian Merchant

  committed
  eaaeef7

  Copy full SHA for eaaeef7

• Deconstructing InputStringKind

  

  Brian Merchant

  committed
  c523ca6

  Copy full SHA for c523ca6

• Removed places where is_string_literal showed up, because we want those

  Show description for 013e036
  

  Brian Merchant

  committed
  013e036

  Copy full SHA for 013e036

• Remove snippet because it is related to the code we just deleted.

  

  Brian Merchant

  committed
  ca9249e

  Copy full SHA for ca9249e

• Removed ParseMode; only interested in format not inline_asm.

  

  Brian Merchant

  committed
  9f62d32

  Copy full SHA for 9f62d32

• Remove style because of hypothesis: we will not be dealing with raw string literals, as our raw string literals will already have been processed as a string literal by the compiler?

  

  Brian Merchant

  committed
  76ce23a

  Copy full SHA for 76ce23a

• We can now extract named arguments from a format literal string.

  

  Brian Merchant

  committed
  95cbe6d

  Copy full SHA for 95cbe6d

• Getting the explicit arguments in order.

  

  Brian Merchant

  committed
  468e0ab

  Copy full SHA for 468e0ab

• Correctly removing items from inline_named_args, instead of filtering explicit_args.

  

  Brian Merchant

  committed
  7d3637c

  Copy full SHA for 7d3637c

Commits on Oct 11, 2023

• Functionality for matching explicit arguments discovered in macro input, to arguments discovered in format string literal.

  

  Brian Merchant

  committed
  35ad77c

  Copy full SHA for 35ad77c

• ANSI generic macro is complete.

  

  Brian Merchant

  committed
  65dd0e9

  Copy full SHA for 65dd0e9

• Format args macro seems to work.

  

  Brian Merchant

  committed
  83764af

  Copy full SHA for 83764af

• Playing around with structure of AnsiGenericFmtArgs.

  

  Brian Merchant

  committed
  83d1eb6

  Copy full SHA for 83d1eb6

Commits on Oct 12, 2023

• By-passing the object cloning restriction by creating a method which returns

  Show description for aab52ca
  

  Brian Merchant

  committed
  aab52ca

  Copy full SHA for aab52ca

• Sort of working, good enough for now.

  

  Brian Merchant

  committed
  213a5ee

  Copy full SHA for 213a5ee

• Working fully.

  

  Brian Merchant

  committed
  40e1fe1

  Copy full SHA for 40e1fe1

• rename macro to ansi_format

  

  Brian Merchant

  committed
  1173edb

  Copy full SHA for 1173edb

• More docs.

  

  Brian Merchant

  committed
  e5a4d9b

  Copy full SHA for e5a4d9b

• Test fixes.

  

  Brian Merchant

  committed
  2f908e8

  Copy full SHA for 2f908e8

• Remove functionality that allows nesting of styled format_arg-likes.

  

  Brian Merchant

  committed
  f184b9e

  Copy full SHA for f184b9e

• Rename the color based foreground/background functions

  

  Brian Merchant

  committed
  e821103

  Copy full SHA for e821103

• More renaming back to original-ish.

  

  Brian Merchant

  committed
  fe478b3

  Copy full SHA for fe478b3

• Rename prefix_with_reset back to reset_before_style

  

  Brian Merchant

  committed
  72fa2ae

  Copy full SHA for 72fa2ae

• Color's fg method was actually called 'normal' in the past

  

  Brian Merchant

  committed
  954a860

  Copy full SHA for 954a860

• hidden occurrences of prefix_with_reset --- some of these renamings are wrong, because they were named prefix_with_reset (confusingly) before too

  

  Brian Merchant

  committed
  3c40068

  Copy full SHA for 3c40068

• gradient related rename to original

  

  Brian Merchant

  committed
  60c0731

  Copy full SHA for 60c0731

• remove nested strings example

  

  Brian Merchant

  committed
  4dac9d7

  Copy full SHA for 4dac9d7

• re-adding utils.rs

  

  Brian Merchant

  committed
  d9e43fc

  Copy full SHA for d9e43fc

• more changes to match the original, some docs as well

  

  Brian Merchant

  committed
  ce84b30

  Copy full SHA for ce84b30

• more changes to match the original, this time to do with write functions/methods

  

  Brian Merchant

  committed
  a4dbb5f

  Copy full SHA for a4dbb5f

Commits on Oct 13, 2023

• make lots of functions const that weren't before; it is also technically possible to make the style difference calculations const (using while loops, but for now I have not pursued that

  

  Brian Merchant

  committed
  d29ecb1

  Copy full SHA for d29ecb1