Parse command return types #46
Open
+197
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR parses return types for commands and records these in the typechecker, although it doesn't check that the actual result type matches the expected type.
Regarding parsing, I chose to add a
AstNode::InOutTypes(Vec<NodeId>)variant to hold the list of input-output type pairs. Making that list its own node means we can highlight the entire span[ foo -> bar ]in error messages, including the brackets. But if that's not something we need, I can get rid of theInOutTypesvariant and directly store aVec<NodeId>inside eachAstNode::Def. That'd be simpler.