-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rust-toolchain and nix flake #20
Conversation
I'm fine with the toolchain file (to match the version that Nushell uses) but so far, we've refrained from including package manager--specific files (like flakes) from our repos. We created this repository https://github.com/nushell/integrations to gather these kinds of files. Could you put it there instead? |
I fully understand that nix/flake is a little invasive to a project. Let me go over some options, and we can then decide. I am sorry in advance if you were already aware of all the options and you decided to go with integrations repo option. I believe the main things we should evaluate is:
Here are some options I see:
I am biased because I am a nix user, and getting any of the 1/2/3 options would be the best for me. If the cons outweigh the pros for maintainability of this repository, I totally understand and will follow in that direction. Please let me know your preference and I will update this PR. |
I was doing a little more research to see what other repos do and what are the options. envrc/direnv:
flake files:
.gitignore
Final thoughts: Based on the above, I found a way to get the best experience for me (similar to option (1)) with minimal work on my side and with no changes to this repository. If we decide to go with (7 - no support in the repo), we could also consider few minor changes: 7.1 - add Please let me know if you would like to go with any of the options above (or any other direction), and I will be happy to update the PR to match it. If you believe no changes should be made, please just close the PR. |
We had a conversation about our flake.nix policy with the core team and agreed that we won't block people trying to add them. It has been coming up repeatedly and if people are willing to maintain them, then why not, if it makes life easier for Nix users. So we're OK adding flake.nix and friends to the repo (and other Nushell repos). In any case, with these files related to specific tools, it would be good to add a comment there explaining roughly what the files are, e.g., for someone who's never heard about Nix, flakes, direnv, etc. |
bd8497a
to
1b4e654
Compare
Updated the PR
|
OK, cool, we can merge it, but there is a conflict. |
Nix flake provides out-of-the-box development environment for nix users with the right rust version.
Rebased |
Thanks! |
rust-toolchain will allow us to ensure that everyone developing on the repository is using the same version of rust.
Nix flake will provide out-of-the-box development environment for nix users with the right rust version.