-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[izruff] iP #626
Open
izruff
wants to merge
118
commits into
nus-cs2103-AY2425S1:master
Choose a base branch
from
izruff:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[izruff] iP #626
Commits on Jul 11, 2024
-
damithc authored and damithc committed
Jul 11, 2024 Configuration menu - View commit details
-
Copy full SHA for 68c58c1 - Browse repository at this point
Copy the full SHA 68c58c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 03523ec - Browse repository at this point
Copy the full SHA 03523ecView commit details
Commits on Jul 21, 2024
-
build.gradle: Prevent generating a second JAR file
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Configuration menu - View commit details
-
Copy full SHA for 81a9c53 - Browse repository at this point
Copy the full SHA 81a9c53View commit details
Commits on Aug 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for edaa970 - Browse repository at this point
Copy the full SHA edaa970View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f4d559 - Browse repository at this point
Copy the full SHA 2f4d559View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd1abfc - Browse repository at this point
Copy the full SHA dd1abfcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c2c821 - Browse repository at this point
Copy the full SHA 5c2c821View commit details -
Configuration menu - View commit details
-
Copy full SHA for d83548d - Browse repository at this point
Copy the full SHA d83548dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdecfd1 - Browse repository at this point
Copy the full SHA bdecfd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 729d3fd - Browse repository at this point
Copy the full SHA 729d3fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b35bb3 - Browse repository at this point
Copy the full SHA 5b35bb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5cbbeb - Browse repository at this point
Copy the full SHA e5cbbebView commit details -
Configuration menu - View commit details
-
Copy full SHA for 857012c - Browse repository at this point
Copy the full SHA 857012cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c93d0cf - Browse repository at this point
Copy the full SHA c93d0cfView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 55e872b - Browse repository at this point
Copy the full SHA 55e872bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a7b166 - Browse repository at this point
Copy the full SHA 8a7b166View commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75cdc30 - Browse repository at this point
Copy the full SHA 75cdc30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b2770c - Browse repository at this point
Copy the full SHA 7b2770cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d13673b - Browse repository at this point
Copy the full SHA d13673bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b838af6 - Browse repository at this point
Copy the full SHA b838af6View commit details
Commits on Aug 25, 2024
-
Certain errors can occur when user gives an incorrect or badly formatted input, causing the program to exit. Let's handle some of these possibilities, including, * unknown command names, flags, or arguments * missing or duplicated flags, arguments * type validation for arguments * out-of-range errors when accessing task list through `mark` or `unmark`
Configuration menu - View commit details
-
Copy full SHA for 4fc5773 - Browse repository at this point
Copy the full SHA 4fc5773View commit details -
Configuration menu - View commit details
-
Copy full SHA for 972b076 - Browse repository at this point
Copy the full SHA 972b076View commit details
Commits on Aug 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b930d7 - Browse repository at this point
Copy the full SHA 7b930d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2cfe70b - Browse repository at this point
Copy the full SHA 2cfe70bView commit details
Commits on Aug 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 40ac380 - Browse repository at this point
Copy the full SHA 40ac380View commit details -
Configuration menu - View commit details
-
Copy full SHA for 833c3a6 - Browse repository at this point
Copy the full SHA 833c3a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 266b31a - Browse repository at this point
Copy the full SHA 266b31aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cfde52 - Browse repository at this point
Copy the full SHA 7cfde52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67c4c4f - Browse repository at this point
Copy the full SHA 67c4c4fView commit details
Commits on Sep 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0351a2f - Browse repository at this point
Copy the full SHA 0351a2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 841b6b9 - Browse repository at this point
Copy the full SHA 841b6b9View commit details
Commits on Sep 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5f638fc - Browse repository at this point
Copy the full SHA 5f638fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f44fa76 - Browse repository at this point
Copy the full SHA f44fa76View commit details -
Configuration menu - View commit details
-
Copy full SHA for f601341 - Browse repository at this point
Copy the full SHA f601341View commit details
Commits on Sep 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 790aea2 - Browse repository at this point
Copy the full SHA 790aea2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d64de43 - Browse repository at this point
Copy the full SHA d64de43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 100f96b - Browse repository at this point
Copy the full SHA 100f96bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cecc3c - Browse repository at this point
Copy the full SHA 6cecc3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d684da - Browse repository at this point
Copy the full SHA 8d684daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d99b06 - Browse repository at this point
Copy the full SHA 0d99b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 696e9ba - Browse repository at this point
Copy the full SHA 696e9baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b91e9d - Browse repository at this point
Copy the full SHA 5b91e9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f843463 - Browse repository at this point
Copy the full SHA f843463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d36f62 - Browse repository at this point
Copy the full SHA 9d36f62View commit details -
Partially implement Command and refactor Mittens
The Mittens class violates the SLAP principle. The Command class, along with TaskList, Ui, and Storage aims to fix this. This commit serves as confirmation that the prototype AddCommand class works as expected.
Configuration menu - View commit details
-
Copy full SHA for f90170a - Browse repository at this point
Copy the full SHA f90170aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a66297a - Browse repository at this point
Copy the full SHA a66297aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5454335 - Browse repository at this point
Copy the full SHA 5454335View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42cb70c - Browse repository at this point
Copy the full SHA 42cb70cView commit details -
Modify Command and its subclasses
Several fixes and nits are included here: * remove redundant fields result and error * remove type parameter from Command class * add missing call to super's constructor\ * remove unused imports
Configuration menu - View commit details
-
Copy full SHA for 18f66e6 - Browse repository at this point
Copy the full SHA 18f66e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for c66182d - Browse repository at this point
Copy the full SHA c66182dView commit details -
Configuration menu - View commit details
-
Copy full SHA for be8d194 - Browse repository at this point
Copy the full SHA be8d194View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39164a7 - Browse repository at this point
Copy the full SHA 39164a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e8333d - Browse repository at this point
Copy the full SHA 9e8333dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f097245 - Browse repository at this point
Copy the full SHA f097245View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22079d3 - Browse repository at this point
Copy the full SHA 22079d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f6fb1bc - Browse repository at this point
Copy the full SHA f6fb1bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8be896b - Browse repository at this point
Copy the full SHA 8be896bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c6640e - Browse repository at this point
Copy the full SHA 9c6640eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe3fdc - Browse repository at this point
Copy the full SHA 0fe3fdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for eea6246 - Browse repository at this point
Copy the full SHA eea6246View commit details -
Configuration menu - View commit details
-
Copy full SHA for 611e063 - Browse repository at this point
Copy the full SHA 611e063View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e7b078 - Browse repository at this point
Copy the full SHA 5e7b078View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fc2af5 - Browse repository at this point
Copy the full SHA 2fc2af5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 331666e - Browse repository at this point
Copy the full SHA 331666eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e55b1a - Browse repository at this point
Copy the full SHA 3e55b1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f45c68 - Browse repository at this point
Copy the full SHA 3f45c68View commit details -
Configuration menu - View commit details
-
Copy full SHA for d272df3 - Browse repository at this point
Copy the full SHA d272df3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a470a49 - Browse repository at this point
Copy the full SHA a470a49View commit details
Commits on Sep 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0339cd4 - Browse repository at this point
Copy the full SHA 0339cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 507f25e - Browse repository at this point
Copy the full SHA 507f25eView commit details
Commits on Sep 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 10d0fe9 - Browse repository at this point
Copy the full SHA 10d0fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2da1cfd - Browse repository at this point
Copy the full SHA 2da1cfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae4f677 - Browse repository at this point
Copy the full SHA ae4f677View commit details
Commits on Sep 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 48add82 - Browse repository at this point
Copy the full SHA 48add82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23b66b6 - Browse repository at this point
Copy the full SHA 23b66b6View commit details
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 331651c - Browse repository at this point
Copy the full SHA 331651cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c47210d - Browse repository at this point
Copy the full SHA c47210dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d88c6c2 - Browse repository at this point
Copy the full SHA d88c6c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa54976 - Browse repository at this point
Copy the full SHA fa54976View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a98c3f - Browse repository at this point
Copy the full SHA 1a98c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbe4fba - Browse repository at this point
Copy the full SHA dbe4fbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15c92b5 - Browse repository at this point
Copy the full SHA 15c92b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88ff04d - Browse repository at this point
Copy the full SHA 88ff04dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 240fd19 - Browse repository at this point
Copy the full SHA 240fd19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d252ab - Browse repository at this point
Copy the full SHA 2d252abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cd7674 - Browse repository at this point
Copy the full SHA 5cd7674View commit details -
Configuration menu - View commit details
-
Copy full SHA for 95d14a3 - Browse repository at this point
Copy the full SHA 95d14a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e209a9 - Browse repository at this point
Copy the full SHA 7e209a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a93b874 - Browse repository at this point
Copy the full SHA a93b874View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd0ffc2 - Browse repository at this point
Copy the full SHA cd0ffc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 083c7c6 - Browse repository at this point
Copy the full SHA 083c7c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a9c0ef - Browse repository at this point
Copy the full SHA 8a9c0efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54339a5 - Browse repository at this point
Copy the full SHA 54339a5View commit details
Commits on Sep 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2003c7d - Browse repository at this point
Copy the full SHA 2003c7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce94a4 - Browse repository at this point
Copy the full SHA 9ce94a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 894d8b9 - Browse repository at this point
Copy the full SHA 894d8b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e604d36 - Browse repository at this point
Copy the full SHA e604d36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b28d4c - Browse repository at this point
Copy the full SHA 9b28d4cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f25f39 - Browse repository at this point
Copy the full SHA 6f25f39View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 340e6fe - Browse repository at this point
Copy the full SHA 340e6feView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8596c1 - Browse repository at this point
Copy the full SHA f8596c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4dc21dc - Browse repository at this point
Copy the full SHA 4dc21dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a931cdd - Browse repository at this point
Copy the full SHA a931cddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94db3cf - Browse repository at this point
Copy the full SHA 94db3cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0917c2b - Browse repository at this point
Copy the full SHA 0917c2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 07c74b9 - Browse repository at this point
Copy the full SHA 07c74b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b20c07b - Browse repository at this point
Copy the full SHA b20c07bView commit details -
Merge pull request #3 from izruff/branch-A-CodeQuality
Improve CommandParser code quality
Configuration menu - View commit details
-
Copy full SHA for 5e8c468 - Browse repository at this point
Copy the full SHA 5e8c468View commit details -
Configuration menu - View commit details
-
Copy full SHA for 80f59aa - Browse repository at this point
Copy the full SHA 80f59aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c9f07 - Browse repository at this point
Copy the full SHA 53c9f07View commit details -
Configuration menu - View commit details
-
Copy full SHA for d12070e - Browse repository at this point
Copy the full SHA d12070eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 197289d - Browse repository at this point
Copy the full SHA 197289dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3d4a54 - Browse repository at this point
Copy the full SHA c3d4a54View commit details -
Configuration menu - View commit details
-
Copy full SHA for e13dc97 - Browse repository at this point
Copy the full SHA e13dc97View commit details -
Configuration menu - View commit details
-
Copy full SHA for c15f4b5 - Browse repository at this point
Copy the full SHA c15f4b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bab46e - Browse repository at this point
Copy the full SHA 2bab46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef88c69 - Browse repository at this point
Copy the full SHA ef88c69View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32e0dbc - Browse repository at this point
Copy the full SHA 32e0dbcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.