[CS2103T-W17-4] TA Tracker #8

PotatoCombat · 2020-02-12T08:37:13Z

Here are the usernames of our team members:

@Eclmist
@aakanksha-rai
@chuayijing
@fatin99
@PotatoCombat

j-lum

Commit message title doesn't match content of commit.

truevchow

The image of Figure 3 is not updated, even though the .puml file is.
The images in section 3.1.1 are not updated or labelled.

truevchow · 2020-03-25T05:38:08Z

docs/DeveloperGuide.adoc

+1. LogicManager uses the TATrackerParser to first parse the user command.
+
+2. The TATrackerParser sees that the command is of type sort and passes the


TATrackerParser should be in camel case to be consistent with the class name.

truevchow · 2020-03-25T05:44:36Z

docs/DeveloperGuide.adoc

+
+The following sequence diagram shows the sequence of commands that take place
+between the logic and model components of the TA-Tracker when the user enters the
+command 'module add m/CS2103 n/Software Engineering'.


Try to denote quoted commands with different formatting from the main text.

Capeguy · 2020-03-25T05:54:49Z

Feedback for W17-4 DG

Design
a. Figure 1 is incomplete
b. Figure 7 seems excessively large
c. There are figures after Figure 7 which are unlabelled.
Implementation
a. Many unlabelled figures
b. Can use 'code font' for words such as "UniqueModuleList"
c. Figure 10 in 3.2.2. too small
d. Figure 12 in 3.2.3. too small
e. Figure 17 in 3.3.2. too small
f. Figure 19 in 3.3.3. too small
g. Figures in 3.8 does not follow numbering and numbering formatting
h. Figure '2' in 3.8.1 has black font on red background (hard to read)

umaikaze · 2020-03-25T07:56:07Z

Feedback for W17-4 DG

Very little use of IN_LINE_CODE to highlight the in-line code in the first half of the DG, might want to consider using them to increase readability. e.g. TotalEarnings is calculated by multiplying TotalHours with Rate

shenghaoc · 2020-03-25T07:53:12Z

docs/DeveloperGuide.adoc

@@ -1,4 +1,4 @@
-= AddressBook Level 3 - Developer Guide
+= TA-Tracker - Developer Guide


Your UML diagrams can be less cluttered

Especially the sequence diagrams

xuanxinng · 2020-03-25T08:34:54Z

docs/DeveloperGuide.adoc

@@ -96,11 +96,16 @@ The `UI` component,
 image::LogicClassDiagram.png[]


Maybe can modify the diagram above so that these 2 diagrams don't repeat each other??

xuanxinng · 2020-03-25T08:37:01Z

docs/DeveloperGuide.adoc

+.Group Delete - Sequence Diagram
+image::DeleteGroupSequenceDiagram.png[]
+
+1. LogicManager uses the TATrackerParser to first parse the user command.


Words such as LogicManager an be formatted to look nicer:)

xuanxinng · 2020-03-25T08:41:13Z

docs/DeveloperGuide.adoc

+class structure is used.
+
+.Sort Commands - Class Diagram
+image::SortCommandsClassDiagram.png[]


The words here are a little small to see (compared to the other diagrams) so maybe can change the sizing of the words!

…2103T-W17-4/main into test/session-view

… into test/session-view

…103T-W17-4/main into Aakanksha/Reposense

Add reposense compatibility

Final changes

Add PPP

Update about us

Dg fix

Fix message in AboutUs

Fix EditSessionCommand error

update dg

Fix bugs found

Fix editing sessions with invalid module code

j-lum requested changes Mar 2, 2020

View reviewed changes

Eclmist force-pushed the master branch 2 times, most recently from 03553e5 to 587c311 Compare March 4, 2020 11:35

PotatoCombat force-pushed the master branch from 587c311 to f40a01c Compare March 9, 2020 12:58

truevchow reviewed Mar 25, 2020

View reviewed changes

shenghaoc reviewed Mar 25, 2020

View reviewed changes

xuanxinng reviewed Mar 25, 2020

View reviewed changes

aakanksha-rai and others added 21 commits April 12, 2020 02:01

Increase CommandBox size

329f683

Add markdown

fa56f46

Resize images

b954315

Merge branch 'fix/session-commands' of https://github.com/AY1920S2-CS…

c0871cf

…2103T-W17-4/main into test/session-view

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-W17-4/main…

d95fed2

… into test/session-view

Update Gotosequencediagrasm

5f26b5b

Update Gotosequencediagrasm

87ddcf9

Update Gotosequencediagrasm

4b0a8e1

Fix typos

a2c8b43

Fix typos

f358952

Fix typos

ac3a67a

Fix typos

c976e62

Fix typos

e782ecf

Add caution symbol

a2c3162

Add uml list

16e2f3b

Add Gabe's authorship

b533185

Merge branch 'master' into Aakanksha/Reposense

d03b281

Merge branch 'Aakanksha/Reposense' of https://github.com/AY1920S2-CS2…

c564841

…103T-W17-4/main into Aakanksha/Reposense

Merge pull request #357 from AY1920S2-CS2103T-W17-4/Aakanksha/Reposense

924fa92

Add reposense compatibility

Add uml list

613ad49

Add uml list

d543195

PotatoCombat and others added 30 commits April 13, 2020 22:25

Merge branch 'master' into final/Changes

2413794

Add PPP

c531d33

Remove check when adding and editing duplicate sessions

33ab138

Trim trailing whitespace

9e94ca6

Merge pull request #399 from AY1920S2-CS2103T-W17-4/final/Changes

985f28c

Final changes

Merge branch 'master' into eclmist/ppp

3d7fd54

Merge pull request #400 from AY1920S2-CS2103T-W17-4/eclmist/ppp

4b516c3

Add PPP

Update about us

9e2b448

Merge pull request #401 from AY1920S2-CS2103T-W17-4/eclmist/PPP-update

24f0914

Update about us

Remove DG links

1f16883

Update about us

ef83c9b

Merge branch 'master' into dg-fix

710b949

Update PPP

840a428

PPP update

8090bdf

Merge pull request #402 from AY1920S2-CS2103T-W17-4/dg-fix

f168266

Dg fix

Fix message in AboutUs

0892ea7

Merge pull request #404 from AY1920S2-CS2103T-W17-4/fix/about-us

80cd3d8

Fix message in AboutUs

Fix EditSessionCommand

75b8ab1

Merge pull request #405 from AY1920S2-CS2103T-W17-4/fix/session-edit

4224887

Fix EditSessionCommand error

Fix AddSessionCommand to allow duplicate sessions

dabbabc

Fix constraint messages for dates and times

e84f3a4

Remove done sessions from sample data

4527b47

Changed logging levels to Warning

934ab62

update dg

815a102

Merge pull request #407 from AY1920S2-CS2103T-W17-4/Fastgame-dg-fix

14be8b2

update dg

Fix timing when adding and editing sessions

1a0154d

Merge branch 'master' into fix/bugs

a739249

Merge pull request #406 from AY1920S2-CS2103T-W17-4/fix/bugs

8539f0d

Fix bugs found

Fix editing sessions with invalid module codes

0bcd8fb

Merge pull request #408 from AY1920S2-CS2103T-W17-4/fix/edit-session

409cddd

Fix editing sessions with invalid module code

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2103T-W17-4] TA Tracker #8

[CS2103T-W17-4] TA Tracker #8

PotatoCombat commented Feb 12, 2020

j-lum left a comment

truevchow left a comment

truevchow Mar 25, 2020

truevchow Mar 25, 2020

Capeguy commented Mar 25, 2020

umaikaze commented Mar 25, 2020 •

edited

Loading

shenghaoc Mar 25, 2020

shenghaoc Mar 25, 2020

xuanxinng Mar 25, 2020

xuanxinng Mar 25, 2020

xuanxinng Mar 25, 2020

		1. LogicManager uses the TATrackerParser to first parse the user command.

		2. The TATrackerParser sees that the command is of type sort and passes the

		@@ -1,4 +1,4 @@
		= AddressBook Level 3 - Developer Guide
		= TA-Tracker - Developer Guide

		@@ -96,11 +96,16 @@ The `UI` component,
		image::LogicClassDiagram.png[]

[CS2103T-W17-4] TA Tracker #8

Are you sure you want to change the base?

[CS2103T-W17-4] TA Tracker #8

Conversation

PotatoCombat commented Feb 12, 2020

j-lum left a comment

Choose a reason for hiding this comment

truevchow left a comment

Choose a reason for hiding this comment

truevchow Mar 25, 2020

Choose a reason for hiding this comment

truevchow Mar 25, 2020

Choose a reason for hiding this comment

Capeguy commented Mar 25, 2020

umaikaze commented Mar 25, 2020 • edited Loading

shenghaoc Mar 25, 2020

Choose a reason for hiding this comment

shenghaoc Mar 25, 2020

Choose a reason for hiding this comment

xuanxinng Mar 25, 2020

Choose a reason for hiding this comment

xuanxinng Mar 25, 2020

Choose a reason for hiding this comment

xuanxinng Mar 25, 2020

Choose a reason for hiding this comment

umaikaze commented Mar 25, 2020 •

edited

Loading