[CS2103T-W16-3] StudyBuddy #55

teikjun · 2020-02-26T05:26:25Z

The pull request for Team W16-3

mpang45456 · 2020-03-04T08:46:18Z

docs/DeveloperGuide.adoc

@@ -297,33 +297,32 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un
 |Priority |As a ... |I want to ... |So that I can...
 |`* * *` |new user |see usage instructions |refer to instructions when I forget how to use the App

-|`* * *` |user |add a new person |
+|`* * *` |user |add a new task |


By removing persons object from your project, does this mean that there's no longer a address book functionality at all?

mpang45456 · 2020-03-04T08:49:01Z

docs/DeveloperGuide.adoc

@@ -347,7 +346,7 @@ _{More to be added}_
 == Non Functional Requirements

 .  Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `11` or above installed.
-.  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
+.  Should be able to hold up to 1000 tasks without a noticeable sluggishness in performance for typical usage.


noticeable sluggishness should be quantified (e.g 300ms or smth)

xuanxinng · 2020-03-04T08:42:59Z

docs/DeveloperGuide.adoc

@@ -297,33 +297,32 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un
 |Priority |As a ... |I want to ... |So that I can...
 |`* * *` |new user |see usage instructions |refer to instructions when I forget how to use the App



Can filtering searches be added as a user story?

xuanxinng · 2020-03-04T08:45:13Z

docs/DeveloperGuide.adoc

@@ -347,7 +346,7 @@ _{More to be added}_
 == Non Functional Requirements



Any more NFRs to add? e.g. should be NUS student, response time of system

Kangwkk · 2020-03-04T08:54:40Z

docs/DeveloperGuide.adoc

@@ -347,7 +346,7 @@ _{More to be added}_
 == Non Functional Requirements

 .  Should work on any <<mainstream-os,mainstream OS>> as long as it has Java `11` or above installed.
-.  Should be able to hold up to 1000 persons without a noticeable sluggishness in performance for typical usage.
+.  Should be able to hold up to 1000 tasks without a noticeable sluggishness in performance for typical usage.


need to be more specific about what is a noticeable sluggishness

okkhoy · 2020-03-23T15:27:33Z

Please retitle the PR with the correct format.

suwoons · 2020-03-25T07:35:36Z

Section 3.1.2

Small typo in "list of tasks due soon will b e initialized"

Section 3.2.1

Small typo in "displays a calendar fo users"

Generally clear and understandable, but perhaps having at least one class diagram for your modules such as Calendar or the Due Soon Task feature would enhance the comprehensiveness of your DG :)

wxwxwxwx9

Overall, there were some flaws in the UML diagrams.

wxwxwxwx9 · 2020-03-27T02:32:24Z

docs/DeveloperGuide.adoc

@@ -98,39 +123,34 @@ image::LogicClassDiagram.png[]
 *API* :


For the logic component diagram, it seems like a lot of things were changed (e.g. ArgumentMultimap, Tokenizer) but from what I've seen from the codebase, those classes seems to be still there. Is this intended?

Also, there is no interaction between the logic class and parser class, which is a little weird because typically they are related to one another.

wxwxwxwx9 · 2020-03-27T02:35:23Z

docs/DeveloperGuide.adoc


-NOTE: The lifeline for `UndoCommand` should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram.
+image::DueSoonSequenceDiagram.png[width = "600", length = "500"]


Is the group still using AddressBook model? If not, remember to remove it / rename it appropriately from your sequence diagram!

Also, is there any arguments taken in by the functions? E.g. execute(), addDueSoonTask

For the cross that indicates a deletion, remember to place it a further ahead (not directly on the end of the lifeline bar)

Consider color coding the different sections (e.g. model, logic, ui) for better readability

wxwxwxwx9 · 2020-03-27T02:48:40Z

docs/DeveloperGuide.adoc

+Activity diagram for step 4:
+
+image::TaskSummaryWithRefreshCommandActivityDiagram.png[width = "400", length = "600"]


The conditions that come after "find any task with expired status" should be more explicit, maybe you can consider [has expired status], [else].

Also, remember to join the node back after your conditions are executed.

wxwxwxwx9 · 2020-03-27T02:52:04Z

docs/DeveloperGuide.adoc

+
+Activity diagram:
+
+image::CalendarActivityDiagram.png[width = "400", length = "600"]


I believe the command box for (day < Month.length) is not compliant with the activity diagram we were taught? Also, the if else condition should have square bracket.

duongphammmm

Overall good ideas, but maybe your implementation could be done with a bit more consideration and more detailed documentation!

duongphammmm · 2020-03-27T02:31:10Z

docs/DeveloperGuide.adoc

@@ -79,15 +81,38 @@ image::UiClassDiagram.png[]

 *API* : link:{repoURL}/src/main/java/seedu/address/ui/Ui.java[`Ui.java`]

-The UI consists of a `MainWindow` that is made up of parts e.g.`CommandBox`, `ResultDisplay`, `PersonListPanel`, `StatusBarFooter` etc. All these, including the `MainWindow`, inherit from the abstract `UiPart` class.
+The UI consists of a `MainWindow` that is made up of parts e.g.`BrandingLabel`, `TaskListPanel`,


Consider changing the name of the classes at least to make them consistent with your application (from Person to Task)

duongphammmm · 2020-03-27T02:32:50Z

docs/DeveloperGuide.adoc

-As a more OOP model, we can store a `Tag` list in `Address Book`, which `Person` can reference. This would allow `Address Book` to only require one `Tag` object per unique `Tag`, instead of each `Person` needing their own `Tag` object. An example of how such a model may look like is given below. +
- +
-image:BetterModelClassDiagram.png[]
-
 [[Design-Storage]]


Similarly, change class names here as well to make it consistent!

duongphammmm · 2020-03-27T02:34:27Z

docs/DeveloperGuide.adoc


-Step 1. The user launches the application for the first time. The `VersionedAddressBook` will be initialized with the initial address book state, and the `currentStatePointer` pointing to that single address book state.
+   Command: add


Should add the syntax of the command instead of just the command word itself, e.g.: add n/ NAME t/ [TAG]...

duongphammmm · 2020-03-27T02:39:12Z

docs/DeveloperGuide.adoc

-image::UndoRedoState4.png[]
+Step 1. The user launches the application with some alive and archived task records in the `storage`.
+Statistics will perform on the records retrieved, and the result will be visualized as different charts organized in a `tab panel`.
+After the user clicks `Statistics -> Task Summary`, the `tab panel` will display.


This might not be complying to the project requirement of CLI? is there a CLI command for this?

duongphammmm · 2020-03-27T02:42:12Z

docs/DeveloperGuide.adoc

+
+The task summary feature allows user to enjoy visualized and real-time statistics of their tasks' information.
+
+This feature is implemented using different charts as `pie chart`, `area chart`, `bar chart` and `line chart`.


I'm not sure how these charts are implemented, are they new classes or just some attributes? maybe for OOP, implement them as new classes and reflect that in model?

duongphammmm · 2020-03-27T02:45:36Z

docs/DeveloperGuide.adoc

-** Pros: Will use less memory (e.g. for `delete`, just save the person being deleted).
-** Cons: We must ensure that the implementation of each individual command are correct.
+==== Implementation
+The calendar feature, as the name suggests, displays a calendar fo users.


typo here at "fo" 😢

duongphammmm · 2020-03-27T02:46:38Z

docs/DeveloperGuide.adoc

+. Displays the name of all tasks on that day in the calendar grid.
+. Access calendars in previous or next month using the buttons on top.
+. Displays more information about tasks for the day on the due soon panel after clicking on a grid. (Not done)
+. Fast forward to a specific year/month using CLI. (Not done)


same concern here about CLI

…nto calendar_command

Updated duplicate feature + documentation

… into calendar_command

Calendar command

Small change in DG

complete uml writeup

DG update

rename ppp

# Conflicts: # docs/DeveloperGuide.adoc # docs/UserGuide.adoc

PPP and DG update

ppp

about us add portfolio for all

merge from team repo

up

- bug fix for due soon tag - bug fix for add module - exception update - UG update

mpang45456 reviewed Mar 4, 2020

View reviewed changes

xuanxinng reviewed Mar 4, 2020

View reviewed changes

Kangwkk reviewed Mar 4, 2020

View reviewed changes

teikjun changed the title ~~Pull request for Team W16-3~~ [CS2103T-W16-3] StudyBuddy Mar 23, 2020

wxwxwxwx9 reviewed Mar 27, 2020

View reviewed changes

duongphammmm reviewed Mar 27, 2020

View reviewed changes

gx-huang and others added 21 commits April 8, 2020 22:07

Checkstyle

44a4afc

Edit test

9c1e5f0

Merge branch 'calendar_command' of https://github.com/gx-huang/main i…

7a9a277

…nto calendar_command

Incomplete merge

69095a2

newline at EoF

46f2828

Edited README.adoc

7ac3e09

Add duplicate + edit

2c2818b

Bug fix

8e20ecf

Bug fix

3e5e6de

UG update

fccac91

DG update

c73564c

DG resize pics

1f8ab86

Updated Documentation

9703e78

Merge conflict fix

939715a

Bugs

1482abf

Merge pull request #261 from souwmyaa/master

c97064b

Updated duplicate feature + documentation

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-W16-3/main…

920f06c

… into calendar_command

Edited UG and some bug fix

7f24c21

Merge pull request #260 from gx-huang/calendar_command

d8b0d4b

Calendar command

Bug fixes in DG

9ae80e7

updates

f138147

teikjun and others added 30 commits April 13, 2020 22:49

complete uml writeup

c21dcfe

Small change

b6a422d

update dg

0120dac

Merge pull request #304 from souwmyaa/master

cbd46d6

Small change in DG

Merge pull request #303 from teikjun/uml

eecf83f

complete uml writeup

rename ppp

c6700d7

PPP update

d0b11bb

DG update

Merge pull request #305 from aegis-bot/master

616a71b

rename ppp

Merge branch 'master' into pr/53

459e961

# Conflicts: # docs/DeveloperGuide.adoc # docs/UserGuide.adoc

PPP update

6611e5c

PPP

1e009be

Merge pull request #306 from wyt-sonia/master

15e82e8

PPP and DG update

ppp

6c9ca36

about us add portfolio for all

557c047

Merge pull request #307 from teikjun/last

afd016e

ppp

Merge pull request #308 from aegis-bot/master

3441af0

about us add portfolio for all

up

f20f731

Merge pull request #53 from AY1920S2-CS2103T-W16-3/master

a031001

merge from team repo

Merge pull request #309 from wyt-sonia/master

18b62bd

up

DG merge conflict fix

0790da1

Improved Exit command message

77aa9b9

Improve clear command message

fd9305f

bug fix

bf462cc

- javaDoc update

9f03f6e

- bug fix for due soon tag - bug fix for add module - exception update - UG update

Pic update

a2b2866

Adjusted pictures

e4b4700

Pic improve

6195e36

Merge branch 'master' of https://github.com/AY1920S2-CS2103T-W16-3/main

ddddb6f

Bug fix

e89284d

Fix refresh tags

60421f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CS2103T-W16-3] StudyBuddy #55

[CS2103T-W16-3] StudyBuddy #55

teikjun commented Feb 26, 2020

mpang45456 Mar 4, 2020

mpang45456 Mar 4, 2020

xuanxinng Mar 4, 2020

xuanxinng Mar 4, 2020

Kangwkk Mar 4, 2020

okkhoy commented Mar 23, 2020

suwoons commented Mar 25, 2020

wxwxwxwx9 left a comment

wxwxwxwx9 Mar 27, 2020

wxwxwxwx9 Mar 27, 2020

wxwxwxwx9 Mar 27, 2020

wxwxwxwx9 Mar 27, 2020

duongphammmm left a comment

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

duongphammmm Mar 27, 2020

		@@ -297,33 +297,32 @@ Priorities: High (must have) - `* * \`, Medium (nice to have) - ` \*`, Low (un
		\|Priority \|As a ... \|I want to ... \|So that I can...
		\|`* * *` \|new user \|see usage instructions \|refer to instructions when I forget how to use the App

		@@ -347,7 +346,7 @@ _{More to be added}_
		== Non Functional Requirements


		NOTE: The lifeline for `UndoCommand` should end at the destroy marker (X) but due to a limitation of PlantUML, the lifeline reaches the end of diagram.
		image::DueSoonSequenceDiagram.png[width = "600", length = "500"]

		Activity diagram for step 4:

		image::TaskSummaryWithRefreshCommandActivityDiagram.png[width = "400", length = "600"]


		Activity diagram:

		image::CalendarActivityDiagram.png[width = "400", length = "600"]


		Step 1. The user launches the application for the first time. The `VersionedAddressBook` will be initialized with the initial address book state, and the `currentStatePointer` pointing to that single address book state.
		Command: add


		The task summary feature allows user to enjoy visualized and real-time statistics of their tasks' information.

		This feature is implemented using different charts as `pie chart`, `area chart`, `bar chart` and `line chart`.

[CS2103T-W16-3] StudyBuddy #55

Are you sure you want to change the base?

[CS2103T-W16-3] StudyBuddy #55

Conversation

teikjun commented Feb 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okkhoy commented Mar 23, 2020

suwoons commented Mar 25, 2020

wxwxwxwx9 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duongphammmm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment