-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103-W15-4] Pet Store Helper #4
base: master
Are you sure you want to change the base?
[CS2103-W15-4] Pet Store Helper #4
Conversation
Usernames of team members: @shenghaoc @tianqi77 @Zhu-Ruicong @limdylan |
I like how Model was edited from the default version with specific changes. It is more clear with the Model to understand the codebase. You may find it helpful to draw class diagrams before you implement all classes as it will allow all members of the team to come to a clear consensus about the functionality and structure of each class. |
I think it would be good to include some diagrams in the implementations section when explaining a feature. It would be helpful for the developer to visualise the flow of the feature when reading. |
Some of the classes mentioned in the Developer Guide are not introduced before, so it is not clear what they refer to. Subsequently, it would be good to introduce all relevant classes systematically, so that there is coherent flow. |
docs/DeveloperGuide.adoc
Outdated
|
||
image::UndoRedoState3.png[] | ||
image::displayDiagram2.png[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayDiagram2 not showing.
docs/DeveloperGuide.adoc
Outdated
|
||
image::UndoRedoState1.png[] | ||
image::displayDiagram1.png[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
displayDiagram1 not showing.
==== Proposed Implementation | ||
// tag::display[] | ||
=== Display | ||
==== Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can include an activity diagram to facilitate understanding.
|
Fix calendar related bugs
…into branch-visual-improvements
…into save-and-load
Bug fix adding food
Fix more calendar related bugs
Branch visual improvements
… documentation
Documentation
change feedback message
…into finalized-model-class-diagram
Finalized model class diagram
…into update-docs
…into dev-guide-manual-testing
…into ug-update # Conflicts: # docs/UserGuide.adoc
…into update-docs
Added some FAQ on UG
…into update-docs
Update documents for shenghaoc
…into dev-guide-manual-testing
Dev guide manual testing
No description provided.