-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103-T09-2] iTrack Pro #37
base: master
Are you sure you want to change the base?
[CS2103-T09-2] iTrack Pro #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do see below for our feedback. Keep it up!
docs/DeveloperGuide.adoc
Outdated
_{More to be added}_ | ||
|`*` |lazy user |keep track of previous inputs |enter/edit previous commands easily | ||
|
||
|`*` |lazy user |access <<product, products>> that are running low easily |restock and update the system much faster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, but what exactly does "access products that are running low" mean? Not very sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can rephrase as "List products that are running low".
docs/DeveloperGuide.adoc
Outdated
|
||
|`* *` |user |set the inventory quantity low limit |get notified when my stock is running low | ||
|
||
|`* *` |user |view the top-selling <<product, products>> and worst-selling <<product, products>> at one glance (e.g. dashboard that displays name of <<product, products>>) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite similar to the "view a list of products sorted by the amount of sales" below. Perhaps make it clearer that this is more UI-focused?
|
||
[none] | ||
* 2a. The list is empty. | ||
+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe can add a line on how the application will handle this special case.
|
||
|`*` |lazy user |access <<product, products>> that are running low easily |restock and update the system much faster | ||
|
||
|======================================================================= | ||
|
||
[appendix] | ||
== Use Cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All use cases are missing preconditions, guarantees etc. Would be good to add more information.
3. User requests to delete a specific person in the list | ||
4. AddressBook deletes the person | ||
1. User requests to list items. | ||
2. The app displays a list of requested items. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This listing functionality is already under UC05 below. Should reference it.
docs/DeveloperGuide.adoc
Outdated
|
||
1. User requests to view statistics. | ||
2. The app shows all statistics. | ||
3. User requests to predict sales for next month. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a separate use case, as sales prediction is quite a big use case, and may have quite a few extensions..
Plot daily product sales
Delete transactions with product when product is deleted
Update UG and sort Products by remaining balance automatically
Delete transactions with customer when customer is deleted, fix stats…
Updated styling of StatisticsListPanel with CSS
Update stats window ui, fix edit transaction
Fix jar file from throwing NPE due to invalid path name
Fix jar file issues
# Conflicts: # src/main/java/seedu/address/logic/parser/customer/AddCustomerCommandParser.java
add transaction command parser test
Add tests
Remove unused code
Update UG and DG
Rename YingxuH.adoc to yingxuh.adoc
Team PR
@YingxuH
@aliciatxl