[CS2103-W14-1] Courses Management #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BransonNg
reviewed
Mar 25, 2020
There was a problem hiding this comment.
Overall, looks great! Nice enhancements to your DG and nice diagrams!!
However, we noticed a couple of things:
Figure 9
- there's a rogue textbox with "text" in it
- the getFactory does not seem to fit the format of a class diagram's method description
- Class diagram also shouldn't show a simplified flow
- AssignCommandBase's COMMAND_WORD should be a static attribute? (we're not too sure either based on just diagrams)
- Maybe the modifiers should be used consistently
Figure 10
- Relationships indicated between classes should be represented as either attributes or lines with the multiplicity (for e.g. between Progress and ID -> you should only choose one)
Figure 12
- There some arrows in the diagram that overlap. Those classes could perhaps be shifted to the left to reduce the overlap.
General
Diagram designs can be more consistent throughout the DG
completed undo/redo for assign
getIndex return index of obj in the list in address book
Implement Clear command
Developer guide restructure
Developer guide restructure
EdgeManager support for opposite Command of delete
Update DeveloperGuide.adoc
Fix bug with clear-all command
…into fix_ui_bug
ivan's ppp
Instructions for Manual Testing
Update ShengXue PPP
updated DG
Completed effort
correct diagram
changed name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.