[CS2103-T09-1] Modulo #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junhaotan
reviewed
Mar 5, 2020
|
|
||
| |`* * *` |user |find a person by name |locate details of persons without having to go through the entire list | ||
| |`* * *` |user |categorise my work based on module |don’t have to manually categorise myself |
There was a problem hiding this comment.
Good to rephrase "don't have to manually categorise myself". Sounds informal.
docs/DeveloperGuide.adoc
Outdated
| . Should be able to run seamlessly with 10 <<module,module>>s’ worth of data. | ||
| . Data should be persistent within the local machine and the save file should be editable. | ||
| . The application should not require an installer and be for a single user, with its size being smaller than 100mb. | ||
| . Object-oriented. |
There was a problem hiding this comment.
Perhaps it is not an NFR. Since it cannot be tested.
docs/DeveloperGuide.adoc
Outdated
| [[module]] Module:: | ||
| Modules that the User is taking for the current semester. | ||
|
|
||
| [[event]] Event |
There was a problem hiding this comment.
Formatting issue in the adoc. Missing ::
docs/DeveloperGuide.adoc
Outdated
| [[event]] Event | ||
| These are default events for each module, such as Lectures, Tutorials, Recitations, Sectionals etc. All these events are automatically populated from NUS data upon module creation. | ||
|
|
||
| [[deadline]] Deadlines |
test cases for writer package + exportcommand
…into branch-update-parser-test
Branch update parser test
Add slot to event
Update Sean PPP
…into LogicManagerTest
Updated on PPP
Rename file
Update file name
docs: fix issues and add effort
Abstraction of code
added javadocs
chore: Delete TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seanlowcy77
@JingYuOng
@ErnTekTeoh