Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F09-1] Coupon Stash #1

Open
wants to merge 1,183 commits into
base: master
Choose a base branch
from

Conversation

alcen
Copy link

@alcen alcen commented Jan 31, 2020

Hello! We are the proud developers of Coupon Stash, the wildly successful application for managing your many coupons, vouchers and promotions! We regret to inform you that due to excessive demand, we will have to turn down all requests for media interviews.

@nelsontky
@ChesterSim
@Denise-Ng
@kevvvinn

@alcen alcen changed the title [CS2103T-F09-1] Contact List Pro [CS2103T-F09-1] Coupon Stash Feb 14, 2020
NicholasCF pushed a commit to NicholasCF/main that referenced this pull request Feb 29, 2020
. Coupon Stash source code should be covered by tests as much as possible.
. Stash should be easy to use for users, who are not familiar with coding.
. All monetary amounts should be accurate up to 2 decimal places.
. Coupon Stash should be portable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a functional requirement

**Extensions**

[none]
* 1a. STASH detects an error in the entered data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the error detected when the coupon is set to 'used' instead of when the coupon is added?

**Extensions**

[none]
* 1a. STASH detects an error in the entered data.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean 'STASH detects an invalid command'?

[none]
** 1b1. STASH requests the user to enter an index that corresponds with an existing coupon.
** 1b2. User enters new index.
** Use case resumes from step 2.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STASH should loop until correct index is entered

* 1b. STASH detects that the specified coupon does not exist.
[none]
** 1b1. STASH requests the user to enter an index that corresponds with an existing coupon.
** 1b2. User enters new index.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STASH should loop until correct index is provided (and subsequent commands)

@JingYuOng
Copy link

What needs to do:
-The developer guide still have address book' s diagram, can consider rename to coupon book
-For the extension of the edit coupon, (2a2. User enters new data. Steps 2a1 - 2a2 are repeated twice until the data entered are correct.) why user need to repeat twice until data entered are correct. Probably can explain more clearly here.

Good:

  • like the Model#commitCouponStash(String commandText)
  • The design consideration not bad.

nelsontky and others added 30 commits April 13, 2020 22:26
Remove multiplicity from Model class diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants