-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-F09-1] Coupon Stash #1
base: master
Are you sure you want to change the base?
[CS2103T-F09-1] Coupon Stash #1
Conversation
…oc-test Remove codacy
. Coupon Stash source code should be covered by tests as much as possible. | ||
. Stash should be easy to use for users, who are not familiar with coding. | ||
. All monetary amounts should be accurate up to 2 decimal places. | ||
. Coupon Stash should be portable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a functional requirement
docs/DeveloperGuide.adoc
Outdated
**Extensions** | ||
|
||
[none] | ||
* 1a. STASH detects an error in the entered data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is the error detected when the coupon is set to 'used' instead of when the coupon is added?
docs/DeveloperGuide.adoc
Outdated
**Extensions** | ||
|
||
[none] | ||
* 1a. STASH detects an error in the entered data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean 'STASH detects an invalid command'?
[none] | ||
** 1b1. STASH requests the user to enter an index that corresponds with an existing coupon. | ||
** 1b2. User enters new index. | ||
** Use case resumes from step 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STASH should loop until correct index is entered
docs/DeveloperGuide.adoc
Outdated
* 1b. STASH detects that the specified coupon does not exist. | ||
[none] | ||
** 1b1. STASH requests the user to enter an index that corresponds with an existing coupon. | ||
** 1b2. User enters new index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STASH should loop until correct index is provided (and subsequent commands)
What needs to do: Good:
|
History and Saveables in coupon window
Monetary amount no longer saved as double
SetPref to SetCurrency, tests and logging
Your prayer has been answered
Fix typo in Developer Guide
…for result display and help pane
Chester last update
Update Developer Guide glossary
Update help
…se-Ng/main into update-documentation-branch
Update UG DG PPP
Remove multiplicity from Model class diagram
Hello! We are the proud developers of Coupon Stash, the wildly successful application for managing your many coupons, vouchers and promotions! We regret to inform you that due to excessive demand, we will have to turn down all requests for media interviews.
@nelsontky
@ChesterSim
@Denise-Ng
@kevvvinn