forked from se-edu/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W10-4] Know-It-All #23
Open
afterdusk
wants to merge
1,244
commits into
nus-cs2103-AY1819S2:master
Choose a base branch
from
cs2103-ay1819s2-w10-4:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
1244 commits
Select commit
Hold shift + click to select a range
35dc45d
Update CSV test file names
afterdusk d28edfe
Merge pull request #26 from cs2103-ay1819s2-w10-4/master
KerrynEer f8548f4
rename PPP ascii doc
yichong96 ee62436
update PPP intro
yichong96 c9c3a3d
Add data directory warning to QuickStart in UG
afterdusk 66da2b7
Replace previous saveLocation in status bar to currentStatus
KerrynEer 3b785bb
Replace saveLocation with current status in comment
KerrynEer 722ab6a
Update ModelManagerTest and add AddFolderCommandTest
afterdusk 02e7ce9
Add test command logic junit and integration test for an empty folder
KerrynEer c4cb517
Add next command test for the case when there are no more cards in th…
KerrynEer 925d3df
Fix set current tested Card test method name typo
KerrynEer aeea1bb
Correct mistake in set current tested card test method in ModelManager
KerrynEer 40fe8eb
add test for sort command
dlqs 238f1d9
add comparator test
dlqs e52c589
add test for end report
dlqs c54fd83
fix checkstyle
dlqs 767baad
Update StorageManagerTest
afterdusk 82296ec
add system test for report
dlqs fc996e3
Add EditFolderTest
afterdusk 4efd27d
Fix wrong invalid index message for EditFolderCommand
afterdusk 72e85eb
Add DeleteFolderCommandTest
afterdusk 749d68d
Update CardFolderTest
afterdusk 753bbd5
Fix resetData() test bug in CardFolderTest
afterdusk ae2edbb
Refactor testCardFolder() to startTestSession() in model
KerrynEer 9a076dd
Fix typo in comment for sort test in model
KerrynEer 1e50f08
Add getters in Model Manager for testing
KerrynEer 8e9fc6a
Add setup methods for test session related tests
KerrynEer 9a503b3
Add tests for test session ModelManager methods and use assertNull/No…
KerrynEer d98ae69
Revert commit: add test command logic junit and integration test for …
KerrynEer ea5ab7d
Refactor tests and remove redundant ModelManager constructor
afterdusk d9d5b18
Fix bug in StorageManager and update tests accordingly
afterdusk cd5a453
Merge pull request #177 from afterdusk/master
afterdusk 36f569f
Fix checkstyle
KerrynEer 5d2ceaa
Merge pull request #178 from mmdlow/parser
mmdlow fcc0716
Fix merge conflicts and Merge remote-tracking branch 'upstream/master'
KerrynEer f5cadbc
Fix error due to duplicate card folder names for next command test
KerrynEer 6a37add
Remove old comment
KerrynEer c998f86
Refactor some contents in browser panel to flashcard context
KerrynEer 60e5dd1
Update User Guide Quick Start
afterdusk ec7376e
Merge remote-tracking branch 'upstream/master'
afterdusk ab350ee
Further additions to UG Quick Start
afterdusk 1085fb9
Add images and ppt for user guide
KerrynEer db19e90
Update UI.png
afterdusk c89540a
Add newline characters to card added message
mmdlow 2178046
Update User guide
KerrynEer af842ed
Update test session sequence diagram and ui class diagram for DG
KerrynEer aabab51
Update DG
KerrynEer 45fd069
Update PPP
KerrynEer 3086d6c
update documentation
yichong96 c78f059
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
yichong96 ba67f35
Update PPP
afterdusk 12a42e7
Fix typos and rephrase some sentences
afterdusk d771f96
Update Architecture Diagram
afterdusk 7deb651
Add manual testing for test session features in DG
KerrynEer 2aefb17
Remove se-edu bar from website
KerrynEer e4f787c
Update Developer Guide
afterdusk 00552ec
Update sequence diagrams for execute() to include arguments
KerrynEer d751c00
Fix typos in DG and ppp
KerrynEer f90b843
Remove space in manual testing instructions in DG
KerrynEer cf4e915
added UI to PPP and update import export code
yichong96 44e2691
Fix typo in PPP
KerrynEer f32fb0a
update blood csv test
yichong96 fcd7c00
Rename Uimockups file to images for user guide
KerrynEer 9802c49
add test system test
dlqs 01a9512
update comment
dlqs 265bb25
change design considerations to table format
yichong96 9b0700d
fix comment
dlqs 89864a2
Merge pull request #179 from KerrynEer/master
KerrynEer 6e9193e
Merge branch 'master' into minTestScore
dlqs 549be0c
Fix mistakes in DG and PPP
afterdusk 1e8c51b
add preface to design considerations
yichong96 54b644e
fix naming
dlqs 21efddc
Fix merge conflict
afterdusk a3db6dc
Merge pull request #167 from dlqs/minTestScore
dlqs 6614ae7
Add manual testing for folders
afterdusk 071e49e
Merge remote-tracking branch 'upstream/master'
afterdusk 53c947b
Amend sequence diagrams
afterdusk 6d1ba99
Fix checkstyle issues
afterdusk ee28a73
changedd IMPORTANT notation to NOTE
yichong96 265a3bc
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
yichong96 570137c
Replace 'the user' with 'you' in UG
afterdusk 487150f
Update addfolder command in UG to have UI image
afterdusk 389f4eb
Merge pull request #180 from afterdusk/master
KerrynEer 27852f0
add capitalization
dlqs 7054850
update definition
dlqs b806c7a
Fix typos and add some details to docs
KerrynEer 72ebe65
Fix typos in links in design of DG
KerrynEer d280673
Update phrasing and add command format to PPP
KerrynEer 4639594
Enable text overflow in card page ui
mmdlow 5e68152
Add scrollpane to browser panel
mmdlow 9cabf5e
add new sequence diagrams
dlqs 1fb0725
add explaination for report command
dlqs b4017ec
Show browserpanel scrollbar only when needed
mmdlow cfbeee2
update my adoc name
dlqs 3947528
Reduce max length of questions, answers, hints and options to 256
mmdlow 0799e5c
add link to reposense
dlqs eb5cab6
add formating code snippet
dlqs 38ecf85
add new screenshot for report
dlqs e2a7a91
Fix more typos and wordings
KerrynEer f3354e5
Remove Johndoe PPP
KerrynEer 618adf4
fix ordering caption
dlqs fd72b21
Update answer command tests for mcq cards
mmdlow be56e2c
Fix bug with mcq answer test
mmdlow acfa5a0
Fix wording in UG Command Format and PPP
KerrynEer bc9f007
Fix bug with import command test
mmdlow 7038c62
Fix phrasing in DG
KerrynEer a2f4d90
Fix bug with help command system test
mmdlow 2ce2ce3
Update PPP
mmdlow 4126f4e
Merge branch 'master' into dev
mmdlow 93ac3d8
Fix grammer error in DG
KerrynEer e52b7d1
Fix checkstyle
mmdlow b1fc815
update sequence diagram and PPP
yichong96 e895077
Fix bug in answer command test
mmdlow 3036519
fix bug for missing fields csv file
yichong96 af48496
change import command exception message
yichong96 2c99c07
Update PPP
mmdlow 9bf1842
Center card ui display text alignment
mmdlow 8dd7ecb
Add images showing the difference between mcq and single answer in UG
mmdlow 3846963
Update PPP other contributions
mmdlow 6cd69b5
fix parser test
yichong96 8aa337d
Fix typo in DG and remove some links in PPP
KerrynEer 5b2914a
remove UI of KIA from PPP
yichong96 5323b13
Fix more typos in DG
KerrynEer 41f2e39
Cut down on some information in PPP
KerrynEer 4063b91
reduce documentation from PPP
yichong96 29432c5
Mention in PPP that contributions here are excerpts
KerrynEer e7dc8d0
Add card field length constraints to user guide
mmdlow 8b26f74
Add currentTestedCardFolderSize and update sequence diagram
KerrynEer e19bfad
Shorten ug portion in PPP
KerrynEer 4f5a43e
Add tag to PPP
KerrynEer d850285
add red text legend
yichong96 7e8b04e
Bold all instances of Know-It-All in UG
KerrynEer 6372482
Fix grammar error
KerrynEer 78baae7
Update jar file link in UG
afterdusk b72f993
Merge branch 'master' of https://github.com/KerrynEer/main
KerrynEer c6dbe5d
Fix typos in DG
KerrynEer 21a82d7
Merge pull request #183 from KerrynEer/master
KerrynEer 530e611
Update documentation
afterdusk 30567dc
Merge remote-tracking branch 'upstream/master'
afterdusk 27415ba
Merge pull request #185 from mmdlow/dev
mmdlow eaac4e6
Shrink image sizes in PPP
mmdlow 8a1efaf
Merge branch 'master' into dev
mmdlow b6c5dbe
added new blood and typical card folder files
yichong96 020b106
update command summary UG for export
yichong96 a2e86a7
fix merge conflict in files
yichong96 5bce35b
add unit test for messages
dlqs 079d76d
add testing instruction for report
dlqs 7f4fa2c
add sort manual testing
dlqs 47f6050
change import file line endings and added red text for PPP
yichong96 5b5e872
add invalid manual test
dlqs f18ceff
fix missing images on netlify
dlqs be9e71f
fix typo
dlqs 4477b84
Add card section to manual testing section in developer guide
mmdlow e4cb780
Restructure manual testing section of developer guide
mmdlow d4fe23b
add new v2 feature
dlqs 52ac3a2
Update PPP
mmdlow 4207da9
Remove images in PPP
mmdlow e50bdab
Fix bug where check for duplicate cards was not case-insensitive
mmdlow e91daa6
Shrink size of card comparison images in add card section of UG
mmdlow 7c91b6b
Add correct answer ui image to PPP
mmdlow c096d76
Fix formatting in PPP
mmdlow c91f776
Update user guide to describe duplicate card constraints
mmdlow e1a529c
update ppp
dlqs d9f487b
fix indent
dlqs 279feb9
add new pr
dlqs 173957a
fix indent
dlqs f1d3b2a
fix image
dlqs bd02212
Merge pull request #182 from dlqs/updatedoc
dlqs 37fe1c2
Merge pull request #187 from mmdlow/dev
dlqs 147d23a
Merge remote-tracking branch 'upstream/master'
afterdusk cc87399
change line ending unix
yichong96 05bd312
Update manual testing answer command
KerrynEer 86e309c
Fix bug with select command message
afterdusk 930ccde
add appendix f for dev guide
yichong96 9acb1b8
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
yichong96 346c1c5
update user guide legend
yichong96 314b938
change grey markup legend
yichong96 f9c2e1c
update doc
dlqs 05c7797
Fix Sequence Diagram For Delete Card image not showing
KerrynEer 82bb8f9
Set fxid of browserpanel scrollpane
mmdlow d7f8053
change pos
dlqs 7f018ba
typo
dlqs 0014804
Update report display image in UG
afterdusk c2b189b
add newline
dlqs 5c6756f
Add new line at EOF :) :)
afterdusk 27dab73
change to tip
dlqs 477e169
Fix typo in DG
KerrynEer c0b61f1
change DG design consideration table format
yichong96 ba1ab1d
change to box
dlqs 4349d85
fix checkstyle bugs
yichong96 db4dfb7
Set browserpanel scrollbar to be always present
mmdlow c72b570
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
mmdlow eb9826a
change note
dlqs 981f6e6
Remove browserpanel scrollbar and enable click and drag for card ui
mmdlow 0c9126f
Update User Guide
afterdusk 4ed0906
fix unwanted symbols
yichong96 e2113e3
uppercase
dlqs 436b7dc
Merge pull request #191 from mmdlow/dev
mmdlow 9ba9335
fix additional bugs
yichong96 30c22f4
Merge remote-tracking branch 'upstream/master'
afterdusk c101f50
Fix all links in DG
KerrynEer 1942edb
add collated code preface
yichong96 e1ed47c
add back csv file structure in dev guide
yichong96 6b613bb
Fix UI.png naming error
afterdusk 5ed176e
Merge pull request #186 from afterdusk/master
dlqs 509eeac
Merge pull request #190 from dlqs/moredoc
mmdlow 3d52b87
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
yichong96 452d3cb
Update NFRs
KerrynEer 01df4ff
Merge pull request #181 from yichong96/csvOptionHeader
yichong96 30f29d0
Fix UI images naming in README
KerrynEer 14e1b4d
Fix UG example format in add command
KerrynEer 2b981c5
Merge remote-tracking branch 'upstream/master'
KerrynEer 0cb228d
Fix typo in DG
KerrynEer c867006
Merge branch 'master' of https://github.com/cs2103-ay1819s2-w10-4/mai…
yichong96 a1974c0
Make AnswerCommand and RevealCommand not commit to state history
afterdusk 3905c10
edit documentation
yichong96 e4e29da
Update UG to reflect test session undoability
KerrynEer b35e2a7
Revert "Update UG to reflect test session undoability"
KerrynEer 08e124a
Undo previous commit and make Test Session clear state history
afterdusk f36e56f
Update undo command and test operations docs
KerrynEer c854c7e
update dev guide
yichong96 1718f66
modified glossary
yichong96 8f3dcf2
Bold all instances of Know-it-all in UG
KerrynEer ba663d6
Fix typo
KerrynEer 4eab37a
Make folder names case insensitive
afterdusk 247a0cd
Merge remote-tracking branch 'upstream/master'
afterdusk 5d3b086
Update glossary references in user guide
mmdlow 8fc193d
Rename a variable in EditFolderCommand
afterdusk b2da476
Fix small typo in DG
KerrynEer f4284ff
Remove errors in command summary of user guide
mmdlow 0a06b38
Fix minor error in dev guide
mmdlow e516442
Update PPP
mmdlow 0d5f97b
Fix checkstyle issues
afterdusk 657e5a7
Merge pull request #192 from yichong96/updateDocs
mmdlow 8fd9b84
Revert "Bold all instances of Know-it-all in UG"
KerrynEer ae4cd4e
Merge branch 'master' into dev
mmdlow b324aa9
Merge pull request #194 from mmdlow/dev
mmdlow 28be935
Fix error in resetStates() of VersionedCardFolder
afterdusk abfe19d
Merge remote-tracking branch 'upstream/master'
KerrynEer 70934a5
Merge pull request #193 from afterdusk/master
dlqs e625176
fix wrong size committed
dlqs 461a3e3
Fix typo in link
KerrynEer b266dc9
Merge pull request #189 from KerrynEer/master
yichong96 e6df749
fix div by zeo bug
dlqs b9d9d05
liang's aasserts
dlqs 7204221
Merge branch 'master' of github.com:cs2103-ay1819s2-w10-4/main into b…
dlqs 320445a
yc's changes
dlqs b01d09d
Merge pull request #195 from dlqs/bugfix
dlqs a816abf
Remove PE-specific considerations for PPP
afterdusk 9a6e705
Merge pull request #197 from afterdusk/master
afterdusk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"authors": [ | ||
{ | ||
"githubId": "afterdusk", | ||
"displayName": "AU ...JUN", | ||
"authorNames": ["Liang Jun Au", "Liang Jun", "afterdusk"] | ||
}, | ||
{ | ||
"githubId": "dlqs", | ||
"displayName": "DON...ANG", | ||
"authorNames": ["Donald", "dlqs"] | ||
}, | ||
{ | ||
"githubId": "KerrynEer", | ||
"displayName": "KER...EER", | ||
"authorNames": ["KerrynEer"] | ||
}, | ||
{ | ||
"githubId": "mmdlow", | ||
"displayName": "MAT... DE", | ||
"authorNames": ["Matthew Low", "mmdlow"] | ||
}, | ||
{ | ||
"githubId": "yichong96", | ||
"displayName": "ONG...ONG", | ||
"authorNames": ["Yi Chong Ong", "yichong96"] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm.... is this fake news? 😅