Added sort command #33
Conversation
| @@ -579,6 +586,35 @@ private static String executeListAllPersonsInAddressBook() { | |||
| return getMessageForPersonsDisplayedSummary(toBeDisplayed); | |||
| } | |||
|
|
|||
| /** | |||
| * Displays all persons in the address book to the user; in added order. | |||
There was a problem hiding this comment.
I think this comment is not correct?
| switch(rawArgs.trim()) { | ||
| case "name": return PERSON_DATA_INDEX_NAME; | ||
| case "phone": return PERSON_DATA_INDEX_PHONE; | ||
| case "email": return PERSON_DATA_INDEX_EMAIL; |
There was a problem hiding this comment.
Is it better to put these case strings as constants?
| return name.matches("(\\w|\\s)+"); // name is nonempty mixture of alphabets and whitespace | ||
| //TODO: implement a more permissive validation | ||
| // name is nonempty mixture of alphabets and whitespace and hyphens | ||
| return name.matches("(\\w|\\s|-)+"); |
There was a problem hiding this comment.
Hmm this doesn't seem to be related to sort command? If so, it should have its own PR.
| return phone.matches("\\d+"); // phone nonempty sequence of digits | ||
| //TODO: implement a more permissive validation | ||
| // phone nonempty sequence of digits and hyphens with an optional plus in the front | ||
| return phone.matches("\\+*(\\d+|-)+"); |
|
@sreycodes may I know which exercise this PR is for? Is it the W3.3c branching and 1KLoC of week 3 or 2KLoC of week 5? |
|
Hi @sreycodes, your pull request title is invalid. For PR sent to satisfy a learning outcome, the PR name should be in the format of For team PR, the PR name should be in the format of Please follow the above format strictly and edit your title for reprocessing. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR. |
@bqnguyen94