Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[T10-2] Health Book #111

Open
wants to merge 621 commits into
base: master
Choose a base branch
from
Open

[T10-2] Health Book #111

wants to merge 621 commits into from

Conversation

elroyhaw
Copy link

@elroyhaw elroyhaw commented Oct 4, 2018

@nus-se-pr-bot nus-se-pr-bot requested a review from yunpengn October 4, 2018 03:00
yunpengn
yunpengn approved these changes Oct 4, 2018
View reviewed changes
Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if every member in the team has contributed to the PR.

yunpengn
yunpengn approved these changes Oct 8, 2018
View reviewed changes
Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see your efforts so far. It's good that you have touched documentation, UI, logic and model. Again, I hope to see contribution from all team members.

yunpengn
yunpengn approved these changes Oct 20, 2018
View reviewed changes
Copy link

@yunpengn yunpengn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you try to solve the merge conflict with upstream repo?
  • Contact Us page not updated.
  • About Us page

image

- `User Guide`: there is no license known as `NUS`, see https://choosealicense.com

image

- `Developer Guide`: fix wrong info

image

- Each member must describe the implementation of at least one feature in developer guide.

florafong97 and others added 20 commits November 4, 2018 04:12
@florafong97
no message
121c76d
@florafong97
Prescription differentiated only by name
190cff1
@florafong97
AddPrescriptionCommand to take in appointment without ID + tests
199835b
@florafong97
deletePrescription Commnd to take in appt without prefix + tests
f3d75cc
@florafong97
no message
9024bf7
@florafong97
Merge pull request #82 from florafong97/master
c2a49c4 
Removed appointmentID index for Prescription commands and Tests for DeletePrescriptionCommand
@YangYafei1998
fix bug mentioned in Dry Run
362fd74
@YangYafei1998
no message
2bbed53
@YangYafei1998
fix undo of delete-medical-history
f6f9d6f
@YangYafei1998
checkstyle
e842e5e
@YangYafei1998
no message
e27d909
@YangYafei1998
no message
566ef20
@elroyhaw
Fix RegisterCommands to enforce uniqueness of names
87b93b5
@elroyhaw
Remove whitespaces
8697737
@YangYafei1998
docs
8eac254
@elroyhaw
Merge pull request #98 from YangYafei1998/master
f5fc322 
fix bug mentioned in Dry Run
@elroyhaw
Update relevant test files according to bug fix
a27246a
@elroyhaw
Update relevant test cases
a43c81a
@elroyhaw
Merge pull request #99 from elroyhaw/master
afcc88b 
Fix issues #84, #86, #91
@florafong97
RemarkCommand to take in patient name + tests
28fbc1b
florafong97 and others added 22 commits November 12, 2018 22:06
@florafong97
update images
996b081
@giamjuxian
Update images
5ebfaa9
@giamjuxian
Add calendar component Diagram
101350a
@florafong97
Merge branch 'master' into master
d9a7e32
@elroyhaw
Update DeveloperGuide.adoc
e80e25c
@elroyhaw
Update Portfolio page
f321714
@florafong97
update PPP
02796ff
@florafong97
Merge branch 'master' of https://github.com/florafong97/main
b9555bd
@florafong97
no message
99cde58
@florafong97
no message
2ff03f9
@giamjuxian
Merge pull request #163 from elroyhaw/master
d041cf3 
Change AddressBook to HealthBook for command sequence diagrams
@giamjuxian
Merge pull request #165 from florafong97/master
0d9ee70 
Update PPP and Develper's Guide
@giamjuxian
Merge pull request #164 from giamjuxian/master
45b8550 
Update Project Portfolio Page
@giamjuxian
Update DeveloperGuide.adoc
97e182f
@elroyhaw
Update DeveloperGuide.adoc
bd67105
@giamjuxian
Update DeveloperGuide.adoc
9b5575e
@giamjuxian
Update DeveloperGuide.adoc
0d06c38
@giamjuxian
Update DeveloperGuide.adoc
bd24b13
@giamjuxian
Update DeveloperGuide.adoc
4e8e424
@elroyhaw
Update AboutUs.adoc
af5add7
@elroyhaw
Update UserGuide.adoc
787681b
@elroyhaw
Update DeveloperGuide.adoc
e58f6b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunpengn yunpengn yunpengn approved these changes

Assignees

@yunpengn yunpengn

Labels
Mid-v1.1-Reviewed Mid-v1.4-Reviewed team.2 tutorial.T10 v1.1-Reviewed v1.2-Reviewed v1.3-Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elroyhaw @yunpengn @nus-se-pr-bot @florafong97 @YangYafei1998 @giamjuxian