[T6A1][F11-B3]LEUNG Cheuk Ting #497
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpdavid
reviewed
Mar 3, 2017
| import seedu.addressbook.data.AddressBook; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.storage.StorageFile.StorageOperationException; | ||
|
|
There was a problem hiding this comment.
This class and its methods should have a header comments. If not, developers who needs to inherit from this class will not know how exactly they should override the methods and other developers who write client code for this class will not know how to use it either.
| } | ||
|
|
||
| // add all the abstract function | ||
|
|
There was a problem hiding this comment.
Indentation problem here?. Our coding standard requires you to use 4 spaces instead of tabs. You can configure Eclipse to convert tabs to spaces automatically.
| @@ -83,6 +82,7 @@ private static boolean isValidPath(Path filePath) { | |||
| * | |||
| * @throws StorageOperationException if there were errors converting and/or storing data to file. | |||
| */ | |||
| //used in logic class, need abs function | |||
There was a problem hiding this comment.
If you want to put this as header comment. Pls write it properly.
Header comment should look like this.
/**
* ...
*/
|
@ctleungac Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.