feat(device-page): nav to devices from device page #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add a filtering feature to this dropdown? (example) |
The UI library being used didn't provide that as an out of the box pattern. It could still be done, the effort would just be larger. I would suggest starting with this and then iterating in the future. |
|
@nurikk agree? |
|
I found an easy enough way to do it. Updated PR with filter.
|
|
LGTM, @nurikk could you do a final check here? |
|
@nurikk could I get an approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it arduous to switch between many devices especially if you want to be on the non-default tab.
This PR changes the device page title into a dropdown button allowing users to select another device directly from the device page, while maintaining the current tab they are on.
Screenshots: