Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supprime la variable d'env AVEC_AUTHENTIFICATION_EIDAS #33

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Supprime la variable d'env AVEC_AUTHENTIFICATION_EIDAS #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.site.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ AVEC_ENVOI_COOKIE_SUR_HTTP= # autorise envoi du cookie de session par HTTP avec
AVEC_MOCK= # autorise l'ajout de contextes de serveur mock FC Plus avec valeur true
SECRET_JETON_SESSION= # secret utilisé pour chiffrer et déchiffrer le jeton stocké dans le cookie de session

AVEC_AUTHENTIFICATION_EIDAS= # si renseigné à `true`, passe par le « bridge eIDAS » pour l'authentification
CLE_PRIVEE_JWK_EN_BASE64= # Cle privée utilisée pour déchiffrer les infos utilisateur provenant de eIDAS (données au format JWK, chiffrées en base64)
IDENTIFIANT_CLIENT_FCPLUS= # identifiant d'accès au serveur FC+
SECRET_CLIENT_FCPLUS= # secret d'accès au serveur FC+
Expand Down
3 changes: 0 additions & 3 deletions src/adaptateurs/adaptateurEnvironnement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ const avecMock = () => process.env.AVEC_MOCK === 'true';

const clePriveeJWK = () => JSON.parse(atob(process.env.CLE_PRIVEE_JWK_EN_BASE64));

const fournisseurIdentiteSuggere = () => (process.env.AVEC_AUTHENTIFICATION_EIDAS === 'true' ? 'eidas-bridge' : '');

const identifiantClient = () => process.env.IDENTIFIANT_CLIENT_FCPLUS;

const parametresRequeteJeton = () => ({
Expand All @@ -29,7 +27,6 @@ module.exports = {
avecConnexionFCPlus,
avecMock,
clePriveeJWK,
fournisseurIdentiteSuggere,
identifiantClient,
parametresRequeteJeton,
secretJetonSession,
Expand Down
2 changes: 1 addition & 1 deletion src/api/creationSessionFCPlus.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const creationSessionFCPlus = (config, requete, reponse) => {
: '';

const fournisseurIdentiteSuggere = typeof requete.query.eidas !== 'undefined'
? adaptateurEnvironnement.fournisseurIdentiteSuggere()
? 'eidas-bridge'
: '';

const construisURL = () => adaptateurFranceConnectPlus.urlCreationSession()
Expand Down
2 changes: 0 additions & 2 deletions test/api/creationSessionFCPlus.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ describe('Le requêteur de création de session FC+', () => {
adaptateurChiffrement.cleHachage = () => '';
adaptateurChiffrement.genereJeton = () => Promise.resolve();
adaptateurEnvironnement.avecMock = () => false;
adaptateurEnvironnement.fournisseurIdentiteSuggere = () => '';
adaptateurEnvironnement.identifiantClient = () => '';
adaptateurEnvironnement.urlRedirectionConnexion = () => '';
adaptateurFranceConnectPlus.urlCreationSession = () => Promise.resolve('');
Expand Down Expand Up @@ -118,7 +117,6 @@ describe('Le requêteur de création de session FC+', () => {
it('renseigne le paramètre `idp_hint` avec la valeur `eidas-bridge`', () => {
expect.assertions(1);
requete.query.eidas = '';
adaptateurEnvironnement.fournisseurIdentiteSuggere = () => 'eidas-bridge';

prepareVerificationPresenceElement('idp_hint=eidas-bridge', reponse);
return creationSessionFCPlus(config, requete, reponse);
Expand Down
1 change: 0 additions & 1 deletion test/routes/serveurTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ const serveurTest = () => {
avecConnexionFCPlus: () => true,
avecEnvoiCookieSurHTTP: () => true,
avecMock: () => true,
fournisseurIdentiteSuggere: () => '',
identifiantClient: () => '',
secretJetonSession: () => 'secret',
urlRedirectionConnexion: () => '',
Expand Down
Loading