Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajout d'un bouton connexion eIDAS #17

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Ajout d'un bouton connexion eIDAS #17

merged 2 commits into from
Jun 11, 2024

Conversation

egaillot
Copy link
Collaborator

Screenshot 2024-06-11 at 15 51 52

Ce bouton ne s'affiche que si la variable d'environnement AVEC_AUTHENTIFICATION_EIDAS est renseignée à true.

@egaillot egaillot added the enhancement New feature or request label Jun 11, 2024
@egaillot egaillot requested a review from Fabinout June 11, 2024 13:52
@egaillot egaillot self-assigned this Jun 11, 2024
Copy link
Contributor

@Fabinout Fabinout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codé en binôme

@@ -12,8 +12,12 @@ const creationSessionFCPlus = (config, requete, reponse) => {
? `&contexte_mock=${contexteMock}`
: '';

const fournisseurIdentiteSuggere = typeof requete.query.eidas !== 'undefined'
? adaptateurEnvironnement.fournisseurIdentiteSuggere()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ce code doit disparaître… bientôt 🤞

@@ -12,11 +12,13 @@ const routesBase = (config) => {
'/',
(...args) => middleware.renseigneUtilisateurCourant(...args),
(requete, reponse) => {
const avecConnexionEIDAS = process.env.AVEC_AUTHENTIFICATION_EIDAS === 'true';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On espère que cette ligne de code va également disparaître bientôt 🤞

@egaillot egaillot merged commit a74f4cc into main Jun 11, 2024
4 checks passed
@egaillot egaillot deleted the bouton-eidas branch June 11, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants