🐛(dimail) fix mailboxes import from dimail #612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mailboxes import
mjeammet
changed the title
|
can't reproduce the bug after cleaning of dimail's mailboxes in problematic domain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I tried to import existing mailboxes from dimail for domain and raised an error because the response had an unexpected format.
update dimail response when requesting get_mailboxes
EDIT 06/01 : It seems to be fixed. I'm confused. I'll keep this PR to add tests regarding a new field in dimail's response : "additional Senders".
Proposal
Description...
I'm getting bolossed by json. For an error that does not exist in prod, but I simply can't reproduce the behaviour in responsesMock. Send help, please.