🧑💻(user) fix the User.language
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/fix-user-language-many-migrations
branch
from
c91c098 to
3d64c88
Compare
mjeammet
approved these changes
Dec 18, 2024
It changes nothing actually ^^ but OK, I will add a changelog before merge :) |
sdemagny
approved these changes
Dec 19, 2024
The use of a lazy function here make the Django migration detector to generate a migration every time we run `makemigrations`. This is not mandatory to have a lazy here as the settings are loaded once at runtime beginning. As the choices makes noop migrations, we directly use the setting in the initial migration.
qbey
force-pushed
the
qbey/fix-user-language-many-migrations
branch
from
3d64c88 to
c3007fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The use of a lazy function here make the Django migration detector to generate a migration every time we run
makemigrations.Proposal
This is not mandatory to have a lazy here as the settings are loaded once at runtime beginning.
As the choices makes noop migrations, we directly use the setting in the initial migration.