-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨(teams) add Team dependencies #560
Open
qbey
wants to merge
4
commits into
main
Choose a base branch
from
qbey/teams-add-tree
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qbey
force-pushed
the
qbey/teams-add-tree
branch
from
November 27, 2024 09:38
34da950
to
312bb54
Compare
qbey
force-pushed
the
qbey/teams-add-tree
branch
from
December 5, 2024 14:24
312bb54
to
0d2b578
Compare
qbey
force-pushed
the
qbey/teams-add-tree
branch
7 times, most recently
from
December 18, 2024 10:43
ed99015
to
9ad2678
Compare
qbey
force-pushed
the
qbey/teams-add-tree
branch
from
December 18, 2024 10:49
9ad2678
to
94ab00e
Compare
qbey
force-pushed
the
qbey/teams-add-tree
branch
3 times, most recently
from
December 18, 2024 17:34
500ec8f
to
7e6037b
Compare
sampaccoud
reviewed
Dec 30, 2024
src/backend/core/migrations/0010_team_depth_team_numchild_team_path_and_more.py
Outdated
Show resolved
Hide resolved
qbey
force-pushed
the
qbey/teams-add-tree
branch
4 times, most recently
from
January 6, 2025 13:05
e7202a1
to
9b32890
Compare
6 tasks
qbey
force-pushed
the
qbey/teams-add-tree
branch
4 times, most recently
from
January 8, 2025 13:26
a2c8fc1
to
a2e7d74
Compare
This provides the technical way to create Team trees. The implementation is quite naive.
Also return the parent teams in the user's team endpoints. This is a first implementation which returns a flat list of teams (not a tree). This is not really helpful, but it allows to create hierarchical teams manually (via admin) if an organization needs it.
Also return the parent teams in the user's team endpoints.
This will allow the frontend to represent teams as a tree if needed.
qbey
force-pushed
the
qbey/teams-add-tree
branch
from
January 8, 2025 13:28
a2e7d74
to
dc848dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to allow Teams to be structured in trees to represent actual teams in a company.
Proposal
Add the "tree" to the Team model and update the API endpoints to list parent teams along with the "direct" teams the user has access to.
This first implementation only allows to manually create those team trees.
The API returns flat teams because we did not define the frontend behavior yet, this will be done later when we really know what we want.
The Treebeard has been pimped for PSQL use, and make the different values explicit.
django-treebeard
dependencyTeam
model into an MP node