Skip to content

Commit

Permalink
πŸ§‘β€πŸ’»(dimail) remove 'NoneType: None' log
Browse files Browse the repository at this point in the history
Fixes "NoneType: None" log appearing in debug mode.
  • Loading branch information
sdemagny committed Jan 17, 2025
1 parent 6c83294 commit 0a795f6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ and this project adheres to

### Fixed

- πŸ§‘β€πŸ’»(dimail) remove 'NoneType: None' log in debug mode
- πŸ›(frontend) fix flaky e2e test #636
- πŸ›(frontend) fix disable mailbox button display #631
- πŸ›(backend) fix dimail call despite mailbox creation failure on our side
Expand Down
5 changes: 4 additions & 1 deletion src/backend/mailbox_manager/utils/dimail.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,10 @@ def raise_exception_for_unexpected_response(self, response):
error_content = response.content.decode(response.encoding)

logger.exception(
"[DIMAIL] unexpected error : %s %s", response.status_code, error_content
"[DIMAIL] unexpected error : %s %s",
response.status_code,
error_content,
exc_info=False,
)
raise requests.exceptions.HTTPError(
f"Unexpected response from dimail: {response.status_code} "
Expand Down

0 comments on commit 0a795f6

Please sign in to comment.