Fix minor warnings on the PopoverList component #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oupsi, found a typo and fixed it.
lebaudantoine
force-pushed
the
fix-warning
branch
from
2d7650a to
bd93a06
Compare
Close issue #91. Each <li> element in a list should have a unique key to avoid React warnings. Added unique keys to 'popover' items. Although the 'lang' keys are generated by i18n dependencies and are expected to be unique, this implementation ensures keys are unique and not based on indexes.
lebaudantoine
force-pushed
the
fix-warning
branch
from
bd93a06 to
289c569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix warnings on the popoverlist component.
Proposal
Close #91
Please check commits for more information.