Fix: Error 404 in staging #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
force-pushed
the
fix/nginx-conf
branch
2 times, most recently
from
828e898 to
522c68d
Compare
|
My fix works locally, however, I cannot deploy it to staging to test it. We need to publish the new frontend image to the registry. One amazing enhancement would be to be able having feature branches deployed to a staging environment for review. @rouja |
src/frontend/default.conf
Outdated
Comment on lines
15
to
17
| location ~* \.(css|js|json|png|jpg|jpeg|gif|ico|svg|woff|woff2|ttf|eot)$ { | ||
| expires 30d; | ||
| add_header Cache-Control "public, max-age=2592000"; |
There was a problem hiding this comment.
This makes me thinking:
- we could explicitly say
index.htmlwants no cache - everything in
assets/*can be cached basically forever instead of "only" 30 days, those assets have cache-busting names - other assets (the ones from the
public/dir) we have to watch out because their name always stay the same. It's easy to update a file and forget that it's cached for a long time.
There was a problem hiding this comment.
I have edited my commits to follow your recommendation. I have set no cache for the public/. I'll watch Nginx webinar on caching statics to level up my skills.
There was a problem hiding this comment.
Inspecting the network tab, cache headers on response seems to be properly set. However, I was wondering why the request has a no-cache header.
Configured Nginx to serve index.html for all requests, allowing the client-side router (Wouter) to manage the routing. Added a try_files directive to attempt to serve static files first, falling back to index.html if the requested file is not found. Added an error_page directive to handle 404 errors by internally redirecting to index.html without modifying the URL path. Wouter should make the rest.
Configured Nginx to set caching headers for static assets by adding a location block to match common static file extensions and set an expiration time of 30 days. It should result in faster loading times, reduced bandwidth usage, and a more efficient and responsive user experience. Wdyt @manuhabitela?
ChangeLog won't be any useful before the first release. Save us time, save the world useless computation, remove the CI steps. They'll be added back as soon as they are necessary.
lebaudantoine
force-pushed
the
fix/nginx-conf
branch
from
fc258d7 to
651d0a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It closes #24
I have added some caching on static assets, lmk @manuhabitela wdyt about it.