♻️(frontend) reorganize starting frontend code #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
manuhabitela
commented
Jul 11, 2024
manuhabitela
commented
- we now have "features" to try to organize code by intent instead of code type. everything at the root of frontend, not in feature/, is global
- customized the panda config a bunch to try to begin to have an actual design system. The idea is to prevent using arbitrary values here and there in the code, but rather semantic tokens
- changed the userAuth code logic to handle the fact that a 401 on the users/me call is not really an error per say, but rather an indication the user is not logged in
manuhabitela
force-pushed
the
front-structure
branch
from
128a357 to
38ab047
Compare
lebaudantoine
approved these changes
Jul 11, 2024
| return fetchApi<ApiRoom>( | ||
| `/rooms/${roomId}?username=${encodeURIComponent(username)}` | ||
| ).then((room) => { | ||
| if (!room.livekit?.token) { |
There was a problem hiding this comment.
Suggested change
| if (!room.livekit?.token) { | |
| if (!room?.livekit?.token) { |
There was a problem hiding this comment.
I don't understand why this should be added as when we are here it means the api responded correctly?
There was a problem hiding this comment.
I'll merge as is and change if needed :)
manuhabitela
force-pushed
the
front-structure
branch
from
38ab047 to
8acb67b
Compare
- we now have "features" to try to organize code by intent instead of code type. everything at the root of frontend, not in feature/, is global - customized the panda config a bunch to try to begin to have an actual design system. The idea is to prevent using arbitrary values here and there in the code, but rather semantic tokens - changed the userAuth code logic to handle the fact that a 401 on the users/me call is not really an error per say, but rather an indication the user is not logged in
manuhabitela
force-pushed
the
front-structure
branch
from
8acb67b to
56187cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.