Skip to content

Commit

Permalink
🔥(backend) remove todo items
Browse files Browse the repository at this point in the history
The Pylint job was failing due to those TODO items. In our make lint command sequence,
Pylint runs first. If it fails, Ruff won't run, which is quite inconvenient.

I've extracted those TODOs into an issue for further review.
  • Loading branch information
lebaudantoine committed Jul 17, 2024
1 parent 3f03cfa commit b314ec9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions src/backend/core/api/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,4 @@ def to_representation(self, instance):

output["is_administrable"] = is_admin

# todo - pass properly livekit configuration

return output
1 change: 0 additions & 1 deletion src/backend/core/api/viewsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ def list(self, request, *args, **kwargs):
user = self.request.user

if user.is_authenticated:
# todo - simplify this queryset
queryset = (
self.filter_queryset(self.get_queryset())
.filter(Q(users=user))
Expand Down
1 change: 0 additions & 1 deletion src/backend/core/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ def generate_token(room: str, user, username: Optional[str] = None) -> str:
str: The LiveKit JWT access token.
"""

# todo - define the video grants properly based on user and room.
video_grants = VideoGrants(
room=room,
room_join=True,
Expand Down

0 comments on commit b314ec9

Please sign in to comment.