🐛(i18n/backend) Fix/email in receiving user language #401

rvveber · 2024-11-04T14:02:08Z

Implements the following:

E-mails sent for granting access are sent in the users language if it exists - else they will be sent in system default language
On Language change in the frontend, the language attribute of the user is updated via API.
Fixes to language related Tests
Added helper for language related Tests

Closes #323

rvveber · 2024-11-21T11:40:59Z

@sampaccoud
Would it make sense to refactor the backend user.language choices to ISO639-1?
eg. fr-fr -> fr

AntoLC

Looks good !
A few comments.

@sampaccoud Should we add a migration to make all our current users french by default, because they will all switch to english after that, wdyt ?

src/frontend/apps/impress/src/features/language/api/useChangeUserLanguage.tsx

src/frontend/apps/e2e/__tests__/app-impress/common.ts

src/frontend/apps/impress/src/core/AppProvider.tsx

src/frontend/apps/impress/src/features/language/api/useChangeUserLanguage.tsx

src/frontend/apps/impress/src/features/language/LanguagePicker.tsx

src/backend/core/api/viewsets.py

src/frontend/apps/impress/src/features/language/LanguagePicker.tsx

src/frontend/apps/impress/src/i18n/conf.ts

src/backend/core/tests/documents/test_api_document_invitations.py

AntoLC

🎉 Good job, works perfect ^^

I think Sam wants to have a look at it before merging.

sampaccoud · 2024-12-01T11:17:34Z

I was expecting the language to be set on the user on first logging here:
https://github.com/numerique-gouv/impress/blob/main/src/backend/core/authentication/backends.py#L91

Otherwise how and when is this field set on the user? 🤔

src/backend/core/tests/documents/test_api_document_invitations.py

rvveber · 2024-12-04T11:12:23Z

src/frontend/apps/impress/src/features/language/LanguagePicker.tsx

+  // Switch i18n.language and user.language via API
+  const switchLanguage = (targetLocale: string): void => {
+    const actions: Promise<unknown>[] = [i18n.changeLanguage(targetLocale)];
+
+    if (userData?.id) {
+      actions.push(
+        changeUserLanguage({
+          userId: userData.id,
+          language: targetLocale,
+        }),
+      );
+    }


I was expecting the language to be set on the user on first logging here: https://github.com/numerique-gouv/impress/blob/main/src/backend/core/authentication/backends.py#L91

Otherwise how and when is this field set on the user? 🤔

When we have a user, we will always have a language set on the user, the choice is not nullable.
So we set, whatever has been set on the user, as language in the frontend.

If the user is unsatisfied with the language that is set, he switches it here (code above) and in turn it updates the attribute at the user.

@sampaccoud

Ok but language will default to settings.LANGUAGE_CODE in the backend. Since the user can only be created via a login, it is a pity not to try harder to set the user's language on first login!

I thought users are created through the Identity Provider? I was thinking to let the IdP transmit the preferred language for initial Account creation.

Also since its not nullable, from the frontend, i have no way of knowing, that what is set on the user, was not set by the IdP or by him.

Ok. It could be one possibility but it's not in the case of our idP. If it came from the idP it would have to be added here right as well right?
If it's not set by the idP, you sould set it from the request at the moment of user creation ie on first loggging like I propose?

Ok, i will try to find an elegant way and implement it on monday

Unfortunately, i did not find an elegant way, with the time i had.
I'm in the holidays now and will revist this in january 2025.

E-mails sent for granting access are sent in the receiving users language. Falling back to system default language.

On Language change in the frontend, the user language is updated via API. If user language is available, it will be preferred and set in the frontend.

rvveber force-pushed the fix/email-in-receiving-user-language branch 2 times, most recently from c645b5b to 72b5272 Compare November 4, 2024 14:10

rvveber marked this pull request as draft November 4, 2024 14:27

rvveber force-pushed the fix/email-in-receiving-user-language branch 4 times, most recently from 62ebf55 to 332e770 Compare November 18, 2024 17:20

rvveber force-pushed the fix/email-in-receiving-user-language branch 6 times, most recently from fef3dea to 3b3e90c Compare November 21, 2024 16:46

rvveber requested review from AntoLC and sampaccoud November 21, 2024 16:55

rvveber marked this pull request as ready for review November 21, 2024 16:56

AntoLC reviewed Nov 25, 2024

View reviewed changes

rvveber force-pushed the fix/email-in-receiving-user-language branch 2 times, most recently from b3534d3 to 704550b Compare November 25, 2024 14:50

rvveber requested a review from AntoLC November 25, 2024 14:51

rvveber force-pushed the fix/email-in-receiving-user-language branch from 704550b to d9bad8c Compare November 25, 2024 14:53

AntoLC reviewed Nov 26, 2024

View reviewed changes

src/frontend/apps/impress/src/features/language/LanguagePicker.tsx Outdated Show resolved Hide resolved

src/frontend/apps/impress/src/i18n/conf.ts Outdated Show resolved Hide resolved

src/backend/core/tests/documents/test_api_document_invitations.py Show resolved Hide resolved

rvveber force-pushed the fix/email-in-receiving-user-language branch from d9bad8c to f773350 Compare November 27, 2024 14:30

rvveber requested a review from AntoLC November 27, 2024 14:32

rvveber force-pushed the fix/email-in-receiving-user-language branch 2 times, most recently from 1b5eb7b to 38639c9 Compare November 27, 2024 14:44

AntoLC approved these changes Nov 28, 2024

View reviewed changes

sampaccoud reviewed Dec 1, 2024

View reviewed changes

src/backend/core/tests/documents/test_api_document_invitations.py Outdated Show resolved Hide resolved

rvveber commented Dec 4, 2024

View reviewed changes

rvveber added 2 commits December 4, 2024 12:21

🐛(backend) email invite in receivers language

5ab181c

E-mails sent for granting access are sent in the receiving users language. Falling back to system default language.

✨(frontend) sync user and frontend language

6a562b4

On Language change in the frontend, the user language is updated via API. If user language is available, it will be preferred and set in the frontend.

rvveber force-pushed the fix/email-in-receiving-user-language branch from 62c3dd6 to 6a562b4 Compare December 4, 2024 11:22

rvveber requested a review from sampaccoud December 4, 2024 11:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛(i18n/backend) Fix/email in receiving user language #401

🐛(i18n/backend) Fix/email in receiving user language #401

rvveber commented Nov 4, 2024 •

edited

Loading

rvveber commented Nov 21, 2024 •

edited

Loading

AntoLC left a comment

AntoLC left a comment

sampaccoud commented Dec 1, 2024

rvveber Dec 4, 2024 •

edited

Loading

rvveber Dec 4, 2024

sampaccoud Dec 6, 2024

rvveber Dec 6, 2024 •

edited

Loading

sampaccoud Dec 11, 2024

rvveber Dec 14, 2024 •

edited

Loading

rvveber Dec 18, 2024 •

edited

Loading

🐛(i18n/backend) Fix/email in receiving user language #401

Are you sure you want to change the base?

🐛(i18n/backend) Fix/email in receiving user language #401

Conversation

rvveber commented Nov 4, 2024 • edited Loading

rvveber commented Nov 21, 2024 • edited Loading

AntoLC left a comment

Choose a reason for hiding this comment

AntoLC left a comment

Choose a reason for hiding this comment

sampaccoud commented Dec 1, 2024

rvveber Dec 4, 2024 • edited Loading

Choose a reason for hiding this comment

rvveber Dec 4, 2024

Choose a reason for hiding this comment

sampaccoud Dec 6, 2024

Choose a reason for hiding this comment

rvveber Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

sampaccoud Dec 11, 2024

Choose a reason for hiding this comment

rvveber Dec 14, 2024 • edited Loading

Choose a reason for hiding this comment

rvveber Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

rvveber commented Nov 4, 2024 •

edited

Loading

rvveber commented Nov 21, 2024 •

edited

Loading

rvveber Dec 4, 2024 •

edited

Loading

rvveber Dec 6, 2024 •

edited

Loading

rvveber Dec 14, 2024 •

edited

Loading

rvveber Dec 18, 2024 •

edited

Loading