-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
final project submission #31
base: master
Are you sure you want to change the base?
Conversation
I find that your presentation is not friendly to readers who do not already know what the Lattice Boltzmann method is, or even know some details of how it works. Straight away, you talk about lattice nodes, collision and distribution functions, and then you throw in a D1Q3 for good measure. Why should I know what you are talking about here? You don't show the governing equation for LBM and simply state that it's similar to Navier-Stokes. And there's no reason to call the heat equation a "Navier-Stokes equation which only has the diffusion part." It's just the diffusion equation! The code in this notebook seems to be solving a 1D heat equation. That's what is implied in your first heading. Yet the governing equation that is written in there is the 2D heat equation. What problem are you solving? We are forced to try to figure it out from your code and the final image: in the code, it looks like you are defining a 1D domain between 0 and 1, but the plot covers from 0 to 100. Inspecting some more, we find that you do In the section under the heading "Connection with FD and the Navier-Stokes Equations," you reference a textbook for more details—but there is no reference list in your notebook! Did you notice that you are loading NumPy twice? |
Professor Barba Thanks for your comments on my work . It would be better to illustrate more about the structure of my assignment .I created a separate file named " introduction" . One is needed to start The reliable reference is the first one by "A.A.Mohamad , Lattice Boltzmann It is your right that the reader may confuse about D1Q3 or D2Q9 . I did not I wrote the LBM main formulas (please see the introduction file ) . We can I could not understand your point about "Yet the governing equation that is Relation LBM to Navier-Stokes could be described by "Chapman-Enskog" The best reference for starting is reference one that is why I prioritize In fact choosing a project in FDM or FVM was easier for me because I only Excuse me for illustration to you and thanks again for reviewing my work . Thank you . On Thu, Dec 25, 2014 at 9:12 PM, Lorena A. Barba [email protected]
|
I only saw one notebook, and since it did not include any links to other files, I didn't notice there were more. Digging into your repo, I can see now that there is a bunch of files. This is a bit unwieldy. We either need a table of contents, or hyperlinks to help us navigate the file set. |
Hello Professor I have listed the code based on numbering them . we have one file called On Fri, Dec 26, 2014 at 4:43 PM, Lorena A. Barba [email protected]
|
Professor Barba I have added the file named " Table of Contents " as you said me . Thank you. On Fri, Dec 26, 2014 at 4:43 PM, Lorena A. Barba [email protected]
|
Did you forget to push it to your GitHub? I don't see any updates in the pull request … Thanks! |
I pushed it and can see it in assignment-bank and Final.Project.Hassan On Fri, Dec 26, 2014 at 7:19 PM, Lorena A. Barba [email protected]
|
No description provided.